search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 68 forks source link

php 8.1 related issues #10643

Closed edmund-dunn closed 2 years ago

edmund-dunn commented 2 years ago

PHP Parse error: syntax error, unexpected token "match" in /var/www/html/docroot/vendor/caxy/php-htmldiff/lib/Caxy/HtmlDiff/HtmlDiff.php on line 699

Update drush to v11.

drupal/styleguide Deprecated function: strpos(): Passing null to parameter #1

Deprecated function: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\node_link_report\Plugin\Block\NodeLinkReport->isAllowed() (line 895 of modules/contrib/node_link_report/src/Plugin/Block/NodeLinkReport.php).

EWashb commented 2 years ago

You're working on this for Sprint 66 @edmund-dunn ?

edmund-dunn commented 2 years ago

@EWashb yes, this stemmed from the other PHP 8 ticket.

edmund-dunn commented 2 years ago

Fixed the issue for the Diff module. Just had to explicitly require "caxy/php-htmldiff": "^0.1.14", which is php 8.1 ready. It is a 3rd level dependency of the Diff module.

edmund-dunn commented 2 years ago

Updated drush to v11 which is php8.1 compatible.

EWashb commented 2 years ago

@dawnpruitt for your awareness for reporting

edmund-dunn commented 2 years ago

patched drupal/styleguide for php8.1 compatibility.