department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Create inline content guidance markup with alt text component design #10777

Closed EWashb closed 2 years ago

EWashb commented 2 years ago

Description

After the completion of #10766, we are ready to start the specific markup for the designed alt text guidance component found in this figma file. The desire is that this format could be used in other areas in the CMS where extended help text (aka inline content guidance) can be beneficial

Design Screenshots

These are approved design mockups, for style, layout, placement of elements etc. The important pieces to note are:

Default component with Placeholder text: image Alt text specific component: image

Functionality

  1. This will be a reusable component, able to be used not only for alt text guidance but for inline guidance on other fields in the future as well
  2. All the the inline guidance/content will be developer managed. Meaning, when we add this to future fields, or want to change existing guidance, updating that text will be a developer task.
  3. The expanded guidance - the section visible after the trigger is activated - will be full HTML and will be able to contain bullets, links, bold, etc.
  4. This component will only be added upon request. Editors (us) will not be able to add this ourselves which will therefore eliminate the chance of having a trigger available that leads to an empty section.
  5. NOTE: there currently is not a character count limit on the alt text field, we will not be adding that at this time. That piece of the Figma design can be ignored for now.

Acceptance Criteria

CMS Team

Please check the team(s) that will do this work.

EWashb commented 2 years ago

@laflannery can you look over the specifics of this ticket before the work begins? I would love another set of eyes to make sure I'm not missing anything.

laflannery commented 2 years ago

@EWashb I added a questions/assumptions section, I wasn't positive if the intention of this is to be reusable right away, or if we are just doing a one-off for now but if so I want to confirm functionality.

EWashb commented 2 years ago

Good questions @laflannery. Let's use our meeting today to dive into these

laflannery commented 2 years ago

I updated the Figma file with new text and I updated the screenshots above. NOTE: this is starting text! I haven't reviewed this with anyone but myself so I will probably update this later on next sprint but this should get you started.

For ease of copy/paste, the content I have added is:

Short help text: Adding a clear and meaningful description of the image is important for accessibility. Trigger: Tips for alternative text (But as we discussed this should be dynamic based on field name) Full guidance: Best practices

swirtSJW commented 2 years ago

@laflannery and @EWashb Is this also going to be used in cases of groups of related fields where the guidance may cover how to use multiple fields? Example: operating status, status more_info, status supplemental Those fields need guidance that describes how they work together.

laflannery commented 2 years ago

Aria for Button trigger:

EWashb commented 2 years ago

@swirtSJW sorry I missed this. That's the hope...lots of reuse.

laflannery commented 2 years ago

@swirtSJW and @EWashb I spoke with the UX team and they suggested that we do use this new inline guidance pattern to eventually replace the current hover tooltips we have. The overall purpose is the same - to provide additional information and possible KB links to the editor - so this pattern would make sense. Let me know if either of you have questions on this or need more information

EWashb commented 2 years ago

@laflannery thanks for the update! When we do change this pattern it will require some change management (even if small communication) since it will change an existing pattern that editors have become accustomed to.

laflannery commented 2 years ago

@edmund-dunn Updated guidance:

Short help text: Adding a clear and meaningful description of the image is important for accessibility.

Full guidance: Best practices

Be accurate and descriptive, clearly identify the main purpose of the image. Be concise, ideally no more that 150 characters. Avoid phrases like “image of”, “photo of”, “graphic of”, etc. Leave the file name of the image out of the alt text. Learn more about alt text guidelines