search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Lovell Dev punch list #11026

Closed swirtSJW closed 1 year ago

swirtSJW commented 2 years ago

Description

The following punchlist items have been identified as items to be fixed with Lovell

MVP

Completed Items

Refined

Unrefined

Unticketed

Post MVP

davidmpickett commented 1 year ago

Captain James A. Lovell Federal TRICARE Health Care Center & Captain James A. Lovell Federal VA Health Care Center should have a switch link to each other. This is one of the most important places for the link to appear as this is the location that serves both audiences.

The link isn't appearing because these locations have different end URLs. Propose renaming the TRICARE variant to match the VA version

captain-james-a-lovell-federal-health-care-center captain-james-a-lovell-federal-tricare-health-care-center

[swirt added these two slightly different but related issues to punchlist]

JayDarnell commented 1 year ago

Potential future item (not MVP):

For list pages (stories, events, etc) assigned to the parent system (Lovell Federal health care) we should hide the VA.gov URL notices from the node view (They are currently, perpetually, marked as pending)

[swirt added issue to punchlist]

omahane commented 1 year ago

On this page: lovell-federal-va-health-care/about-us, the https://web-liqqgmzl7tsyfbwyulbkuborufuuttav.demo.cms.va.gov/lovell-federal-tricare-health-care/about-us page is not showing.

Screen Shot 2022-12-06 at 2 18 03 PM

[swirt added issue to punchlist]

JayDarnell commented 1 year ago

Remove "Other nearby VA locations" from the bottom of the locations page for Lovell Federal TRICARE health care.

https://web-liqqgmzl7tsyfbwyulbkuborufuuttav.demo.cms.va.gov/lovell-federal-tricare-health-care/locations/ Screenshot 2022-12-06 at 3 27 48 PM

[swirt ticketed]

davidmpickett commented 1 year ago

On tricare pages the menu item for Health services should come before locations. (validated it is right in the CMS, so this is FE issue)

Additional nuance for this bullet point is that Health Service is showing up as a sub-item of Locations

Screenshot 2022-12-06 143328

[swirt ticketed]

omahane commented 1 year ago

Need to set the Operating Status for Lovell Tricare

Screen Shot 2022-12-06 at 2 38 27 PM

[Swirt - Fixed this one in content on prod] - DONE

JayDarnell commented 1 year ago

New punch list item. We need to be sure the menu items for the system health services under both Lovell VA and Lovell TRICARE are disabled. In the following screenshot the suicide prevention health service is listed in the menu:

Screenshot 2022-12-06 at 3 41 54 PM

[swirt - I updated this in prod. All done]

maxx1128 commented 1 year ago

On tricare pages the menu item for Health services should come before locations. (validated it is right in the CMS, so this is FE issue)

Additional nuance for this bullet point is that Health Service is showing up as a sub-item of Locations

Screenshot 2022-12-06 143328

Also related to this, all the Locations menu links are also appearing as Health Services links. This could be some menu duplication issues.

Screen Shot 2022-12-06 at 3 41 28 PM

[Swirt - I created a ticket for this BUT I also made a change to the menu structure that MIGHT have fixed this but I left the ticket to remind us to check]

davidmpickett commented 1 year ago

TRICARE System Page - "Manage your health online" - should this whole thing be hidden for TRICARE since these are all hardcoded VA links? Screenshot 2022-12-06 145208

[Swirt ticketed https://github.com/department-of-veterans-affairs/va.gov-cms/issues/11832]

omahane commented 1 year ago

[Swirt added all 4 to punchlist]

maxx1128 commented 1 year ago

Lovell federal pages should be checked if they have va in the CMS URL. This could potentially be creating a bug where federal pages aren't being properly cloned for the Tricare side, hence why so many of those pages have correct menu links but no actual pages.

[Swirt - Max I added this ticket which is related to this issue. The reality is all Lovell Federall and Lovell-VA pages are going to come in with "lovell-federall-va-health-care" in the path. We have to rely on what is set for section to be the source of truth for where it should live in the end, not the path it comes in with. ]

JayDarnell commented 1 year ago

On this page: lovell-federal-va-health-care/about-us, the https://web-liqqgmzl7tsyfbwyulbkuborufuuttav.demo.cms.va.gov/lovell-federal-tricare-health-care/about-us page is not showing. Screen Shot 2022-12-06 at 2 18 03 PM

The subpages under About Us are also failing for TRICARE

[Swirt - Covered by this ticket https://github.com/department-of-veterans-affairs/va.gov-cms/issues/11828 ]

maxx1128 commented 1 year ago

I did a quick filter to see which cloned Tricare pages had the incorrect URL structure with lovell-federal-va-health-care' in it, and it was basically all of them (see titles below). I'm going to try and tweak the build process to catch and correct this bug, and see if it fixes the related switch link bug.

[
  'Make an appointment',
  'DAV vans: Transportation for Veterans',
  'Pharmacy',
  'Campus map',
  'Chaplain service',
  'Caregiver support',
  'Homeless Veteran care',
  'LGBTQ+ Veteran care',
  'Suicide prevention',
  'Mental health care',
  'Minority Veteran care',
  'Patient advocates',
  'Returning service member care',
  'Women Veteran care',
  'COVID-19 vaccines',
  'About us',
  'Work with us',
  'Contact us',
  'Programs',
  'Research',
  'Mission and vision',
  'History',
  'Jobs and careers',
  'Internships and fellowships',
  'Volunteer or donate',
  'Doing business with us',
  'Test Event 1 Both',
  'Test Event 2 Both',
  'Leadership',
  'Lovell Federal TRICARE health care Placeholder - Event',
  'TEST A press release for BOTH LOVELL',
  'TEST story for BOTH Lovell',
  'Kristina Naidicz',
  'Sarah Bognanno',
  'Jennifer Corrao',
  'Kim Jones',
  'Alfreda Rhodes-King',
  'Kristina Lecce',
  'Irma A. Sharp',
  'Robert Buckley',
  'Thomas J. Nelson',
  'Mamata Ravipati',
  'Jeremy Hawker',
  'Veronica L. Brittenum',
  'Sharee Taylor',
  'Michael Simmons',
  'Jeremy Pyles',
  'Kathleen Kennedy'
]
swirtSJW commented 1 year ago

I did a quick filter to see which cloned Tricare pages had the incorrect URL structure with lovell-federal-va-health-care' in it, and it was basically all of them (see titles below). I'm going to try and tweak the build process to catch and correct this bug, and see if it fixes the related switch link bug.

[
  'Make an appointment',
  'DAV vans: Transportation for Veterans',
  'Pharmacy',
  'Campus map',
  'Chaplain service',
  'Caregiver support',
  'Homeless Veteran care',
  'LGBTQ+ Veteran care',
  'Suicide prevention',
  'Mental health care',
  'Minority Veteran care',
  'Patient advocates',
  'Returning service member care',
  'Women Veteran care',
  'COVID-19 vaccines',
  'About us',
  'Work with us',
  'Contact us',
  'Programs',
  'Research',
  'Mission and vision',
  'History',
  'Jobs and careers',
  'Internships and fellowships',
  'Volunteer or donate',
  'Doing business with us',
  'Test Event 1 Both',
  'Test Event 2 Both',
  'Leadership',
  'Lovell Federal TRICARE health care Placeholder - Event',
  'TEST A press release for BOTH LOVELL',
  'TEST story for BOTH Lovell',
  'Kristina Naidicz',
  'Sarah Bognanno',
  'Jennifer Corrao',
  'Kim Jones',
  'Alfreda Rhodes-King',
  'Kristina Lecce',
  'Irma A. Sharp',
  'Robert Buckley',
  'Thomas J. Nelson',
  'Mamata Ravipati',
  'Jeremy Hawker',
  'Veronica L. Brittenum',
  'Sharee Taylor',
  'Michael Simmons',
  'Jeremy Pyles',
  'Kathleen Kennedy'
]

@maxx1128 Nice work. This is the related ticket I think https://github.com/department-of-veterans-affairs/va.gov-cms/issues/11828

I think it boils down to that we have to use field _administration (section) to be the source of truth on where a page should appear, and not the path it originally comes in with.

omahane commented 1 year ago

@davidmpickett Does Lovell have any other social media links that we know of? We have: Facebook: https://www.facebook.com/lovellfhcc Twitter: https://twitter.com/lovellfhcc

Those are the only Lovell specific ones.

The other two on their current page are more general: Flickr: https://www.flickr.com/photos/veteranshealth Instagram: https://www.instagram.com/deptvetaffairs/

Screen Shot 2022-12-09 at 9 25 46 AM

Lastly, I don't suppose we know of any Lovell TRICARE or Lovell VA specific accounts, do we?

davidmpickett commented 1 year ago

@christianmburk I don't have any particular insight into their social media. Quick glance seems like they might treat it as a unified presence. I see reposts of VA and DoD in their feed.

omahane commented 1 year ago

Quick glance seems like they might treat it as a unified presence.

Do you think we should use those links that are on the current live Lovell system site and put them in both VA and TRICARE system pages?

Or, if you don't know, would @davidconlon know?

omahane commented 1 year ago

On this task:

menus on the Tricare pages have the following links that go to the VA versions of the page instead of Tricare: About Us, Work With Us, Contact Us, and Programs.

I'm not sure if this is a CMS or FE task. @swirtSJW Do you know?

davidmpickett commented 1 year ago

I just added some additional structure to the punchlist:

davidmpickett commented 1 year ago

Just uncovered a pretty concerning issue with VAMC Facility Health Services. There doesn't seem to be any logic preventing editors from mixing and matching Facilities, Systems, and Sections.

I was able to save a Facility Health Service on staging as nickolas.sanchez@va.gov in a variety of mismatched ways

Screen Shot 2022-12-15 at 4 33 39 PM

Screen Shot 2022-12-15 at 4 34 26 PM

Screen Shot 2022-12-15 at 4 36 43 PM

maxx1128 commented 1 year ago

One refactor that should be tackled in the near future: the getModifiedLovellPage function has a lot of logic around changing the entity URL. This logic should be streamlined/separated to keep it cleaner and remove any unneeded conditions.

https://github.com/department-of-veterans-affairs/content-build/pull/1399#pullrequestreview-1218230040

davidmpickett commented 1 year ago

I am closing this as most of the issues have been resolved and the other issues have their own tickets