department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 68 forks source link

FE: Establish criteria to remove flipper facilities_locator_mobile_covid_online_scheduling #11588

Closed dsinla closed 1 year ago

dsinla commented 1 year ago

Description

As we investigate each Facilities related Flipper, document the criteria and timeline for when it should be removed.

Refer to https://github.com/department-of-veterans-affairs/va.gov-cms/issues/10656

Acceptance Criteria

CMS Team

Please check the team(s) that will do this work.

maxx1128 commented 1 year ago

@kmariepat-cityfriends I did a quick search through the code repos for this flipper (and also the camel case spelling, facilitiesLocatorMobileCovidOnlineScheduling) and it was actually already removed by our team last November.

However, there are still a few references to the feature flag in vets-api, mostly in some test files. Since the flipper has been deleted, the references are now dead code. But once those are gone then this flipper should be 100% gone from the codebase. They're easy to remove so I can open a pull request to do that to wrap this flipper up.

kmariepat-cityfriends commented 1 year ago

@maxx1128 thank you for the rundown, yes please open the PR just don't merge. After that you can move this card to PO review and i'll call it done from there

maxx1128 commented 1 year ago

Here's the branch with the dead code removed: va-11588-remove-mobile-covid-scheduling-flipper

kmariepat-cityfriends commented 1 year ago

closed and implementation card is here: Implement Flipper #13484