department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Evaluate flipper facilities_ppms_suppress_all for removal #11589

Open dsinla opened 1 year ago

dsinla commented 1 year ago

Description

Investigate facilities_ppms_suppress_all flipper for current use and eligibility for removal.

Refer to https://github.com/department-of-veterans-affairs/va.gov-cms/issues/10656

## Tasks
- [ ] Establish eligibility for removal
- [ ] Note outcome in comments
- [ ] Remove if eligible
davidconlon commented 1 year ago

This flipper exists so that if there are problems with the Provider Profile Management System (PPMS) we have the ability to disable all the front-end search interfaces that rely (either fully or partially) on data from PPMS. At this time, the following Facility locator searches rely on data from PPMS:

Agile6MSkinner commented 4 months ago

@jilladams @FranECross @mmiddaugh This flipper audit was done in late 2022. Would it even still be accurate? Are we realistically going to chase this work at any point?

jilladams commented 4 months ago

I don't know how to answer. Does the Platform definitely want us to be removing unused Flippers due to performance overhead on the VA.gov site? Yep. Will we ever choose to prioritize this work? ...I'm not sure. Can we walk away from the tech debt just because we don't intend to prioritize it? ...dunno. If the Platform ever got worked up about Flipper performance again, and put pressure on teams to remove their old flippers: we would definitely have to prioritize this work and the other tickets like it. 🤷‍♀️

Agile6MSkinner commented 4 months ago

Makes sense. Backlog seems like a good place for it for now.