FE: Establish criteria to remove flipper facility_locator_ppms_forced_unique_id

[dsinla]

Description

As we investigate each Facilities related Flipper, document the criteria and timeline for when it should be removed.

Refer to https://github.com/department-of-veterans-affairs/va.gov-cms/issues/10656

Acceptance Criteria

• [ ] Criteria for Flipper removal is created in this ticket

CMS Team

Please check the team(s) that will do this work.

• [ ] Program
• [ ] Platform CMS Team
• [ ] Sitewide Crew
• [ ] ⭐️ Sitewide CMS
• [ ] ⭐️ Public Websites
• [X] ⭐️ Facilities
• [ ] ⭐️ User support

[maxx1128]

I checked content-build and vets-website and found no reference to this flipper in any code files. It's already been removed from the front end, so the only step left is to remove the toggle from vets-api which is an easy change.

[jilladams]

@maxx1128 just saw your Slack DMs. One note here -- we found previously that the name of the flipper as snake case won't always appear in vets-website code. Instead, notes here on how it gets translated to camelCase. That camelCase reference is really what we need to confirm doesn't exist anywhere in the front end.

Can you take another look with that linked comment in mind and confirm if this flipper is safe to remove. (cc @ryguyk )

[jilladams]

Also noting, this flipper is currently enabled in production: https://api.va.gov/flipper/features

[maxx1128]

@jilladams I checked for snake case and camel case on the front-end and neither one is present in the front-end.

[maxx1128]

The branches for removing the flipper from the needed repos are below. No pull requests have been made with them yet, but can be once this flipper is approved for removal.

1. vets-api - va-11593-remove-ppms-forced-unique-id-feature

[jilladams]

@maxx1128 that in mind: can this ticket be closed?

[maxx1128]

@jilladams Yes I think it can be closed as is since it's having zero effect on the front-end from what I can see.

[kmariepat-cityfriends]

Closing this card, Implementation will be completed on #13239