Closed dsinla closed 1 year ago
The following may be relevant Remove feature flag code for facilityLocatorShowCommunityCares https://github.com/department-of-veterans-affairs/va.gov-team/issues/6065
@mmiddaugh The ticket you point out is, indeed, relevant. As far as I can tell, though, this was closed without any meaningful work. The feature flag is still present.
facility_locator_show_community_cares
was replaced with facilities_ppms_suppress_community_care
, which rendered the existing Flipper feature flag (the one in this issue, facility_locator_show_community_cares
) no longer applicable. It can be removed.config/features.yml
can be removed.event_subscriber_spec.rb
needs to be updated to use a different feature toggle for testing.feature_toggles_controller_spec.rb
needs to be updated to use a different feature toggle for testing. It's worth noting that at least one of these tests seems to require a Flipper feature flag that is enabled.Here is a draft PR that implements the vets-website removal outlined below.
facilities_ppms_suppress_community_care
).facility_locator_show_community_cares
that remain.
featureFlagNames.js
. This can be removed.From scrum: Here's a follow-up implementation ticket. That ticket covers:
Closing this issue. The discovery is done. Refer to follow-up ticket for next steps.
Description
As we investigate each Facilities related Flipper, document the criteria and timeline for when it should be removed.
Refer to https://github.com/department-of-veterans-affairs/va.gov-cms/issues/10656
Acceptance Criteria
CMS Team
Please check the team(s) that will do this work.
Program
Platform CMS Team
Sitewide Crew
⭐️ Sitewide CMS
⭐️ Public Websites
⭐️ Facilities
⭐️ User support