When a VBA facility name changes the section name needs to change

swirtSJW commented 2 years ago

Description

When a VBA facility name change comes in via migration from the facility API, The name on the node changes, but if it is a Regional Office, the corresponding section name does not update, so the two become out of sync.

This is also an issue for Vet Centers see #15583

Known Drift

Regional Office	Section
Manchester VA Regional Benefit Office	Manchester VA Regional Benefits Office
Fort Harrison VA Regional Benefit Office at Fort Harrison VA Medical Center	Fort Harrison VA Regional Benefit Office and Fort Harrison VA Medical Center
National Capital Region VA Regional Benefit Office	National Capital Region VA Regional Benefits Office
Boise VA Regional Benefit Office	Boise VA Regional Benefits Office
Honolulu VA Regional Benefit Office at Spark M. Matsunaga Department of Veterans Affairs Medical Center	Honolulu VA Regional Benefit Office and Spark M. Matsunaga Department of Veterans Affairs Medical Center
Milwaukee VA Regional Benefit Office	Milwaukee Regional Benefit Office

Acceptance Criteria

[ ] I expect when a VBA regional office name changes, the corresponding section name should also change
[ ] I expect aliases for all VBA facilities assigned to that regional office should also update to match
[ ] I expect that the name of a VBA facility service for the regional office updates
[ ] I expect that the url alias of a VBA facility service for the regional office updates

implementation details

Likely this should be handled by node update event so that you'd have access to the original and new values, so that the correct section term can be loaded and updated.

Noodling on how to do this

If flagging VBA Regional office

Get Node ID (fron API ID)
Load entity (from NID)
Get Section ID (from entity)
Load term entity (from TID)
Change term name
Save term
Get parent (from TID)
- Reorder each term (alpha order) under parent to alpha order
Save
- Wherever the weight is stored
Get related service entity ids (from facility NID, as referenced by service nodes in the field_office)
Load each service entity (from service NID)
- Update alias
- Save

CMS Team

Please check the team(s) that will do this work.

[ ] Program
[ ] Platform CMS Team
[ ] Sitewide Crew
[ ] ⭐️ Sitewide CMS
[ ] ⭐️ Public Websites
[x] ⭐️ Facilities
[ ] ⭐️ User support

JQuaggles commented 1 year ago

@swirtSJW How often does this happen? Do we have an idea of how often they update the name?

And will/could this potentially be resolved with any of the VBA work, or is this more specific to FL?

ie I'm trying to understand the severity of the issue.

kmariepat-cityfriends commented 1 year ago

When you have a section intrinsically linked to a page title, there should be a runbook to update the section title, there is a redirect involved. There may be technology implementations as well

jilladams commented 1 year ago

Do the updates to the VBA facility name change runbook make this closeable?

swirtSJW commented 1 year ago

This was covered yesterday in refinement: This issue is not related to #13272. It is a current defect that needs to be resolved regardless of editors. This should be handled automatically not by a runbook.

To Josh's earlier question of How often does it happen. I am not sure. We have not been tracking VBAs that long. Mainly going by pattern with VAMCs and Vet Centers that seem to get renamed more often than we thought they should.

swirtSJW commented 1 year ago

There is also the potential that when a Regional office changes name, it will create a new section since it can not find an existing one that matches its own name. This can be even more problematic than having them misnamed, because now its children will be assigned to the old section.

jilladams commented 1 year ago

Likely at risk for sprint boundary. (@kmariepat-cityfriends )

jilladams commented 1 year ago

From mid-sprint:

let's get this into the VBA runbook as a manual step
Then: figure out automating.

No concerns from POs re: sprint boundary.

davidconlon commented 1 year ago

not concerned about missing sprint boundary.

davidmpickett commented 1 year ago

Related tickets that may need to be updated based on implementation of this ticket (or vice versa)

davidmpickett commented 1 year ago

@mmiddaugh and I are meeting with CAIA on 10/11 to talk about VBA facilities naming schema. May make sense to hold this ticket until after that in case there are any decisions that could impact this. See: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/15490

davidmpickett commented 1 year ago

Prescott Vet Center might be the right Vet Center to look at to understand some of the risks/possibilities here. Looks like the Vet Center is now split across 2 different Sections:

dr-cameron-mckinley-department-of-veterans-affairs-veterans-center
- Governs the Prescott Vet Center node
- no users assigns to this section
prescott-vet-center
- Governs all other nodes related to Prescott (services, location list, outstation, etc.) as well as the users

Screenshots

Prescott Vet Center Section governs everything _but_ Prescott Vet Center

![screencapture-prod-cms-va-gov-section-vha-vet-centers-prescott-vet-center-2023-10-06-13_37_28](https://github.com/department-of-veterans-affairs/va.gov-cms/assets/51967950/5f9dec1b-8b2b-44f7-9f32-9bd275a1d01b)

Dr-Cameron-Mckinley Section governs just Prescott Vet Center

![screencapture-prod-cms-va-gov-admin-content-2023-10-06-13_46_51 (1)](https://github.com/department-of-veterans-affairs/va.gov-cms/assets/51967950/fc723633-c349-4f82-819f-79987e0fdba6)

Users assigned to the two sections

![screencapture-staging-cms-va-gov-admin-people-2023-10-06-13_44_35](https://github.com/department-of-veterans-affairs/va.gov-cms/assets/51967950/ec1700a0-9b84-4fe9-8319-5ed791966fb4) ![screencapture-staging-cms-va-gov-admin-people-2023-10-06-13_44_16](https://github.com/department-of-veterans-affairs/va.gov-cms/assets/51967950/185577b2-81ee-4acc-81a0-98b7251c4457)

davidmpickett commented 11 months ago

Marking this as blocked by the Short Name proposal, because if there are multiple names for a VBA facility then this ticket would be dependent on which name is being used to created the Section

xiongjaneg commented 10 months ago

Jan. 4 UX sync, this is blocked on a spike to determine path forward for VBA offices "at" other locations

davidmpickett commented 7 months ago

Moving to National Rollout as it is blocked by a ticket that is postponed till national roll out

davidmpickett commented 7 months ago

Not sure if this is new information, or just a different lens on to the same issue, but using the Facilities audit I found a bunch of "orphaned" VBA facilities that don't have a "Parent system or facility" listed and aren't Regional Offices

vba_orphans.xlsx

omahane commented 2 months ago

Uncovered an issue while working on the Vet Center name change: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19101

omahane commented 2 months ago

Not sure if this is new information, or just a different lens on to the same issue, but using the Facilities audit I found a bunch of "orphaned" VBA facilities that don't have a "Parent system or facility" listed and aren't Regional Offices

vba_orphans.xlsx

@mmiddaugh Can you confirm that these have parent system/facility in Sandy's DB?

department-of-veterans-affairs / va.gov-cms