Closed kevwalsh closed 4 years ago
kevwalsh
commented
4 years ago @swirtSJW I went ahead and added this to Sprint 2 and estimated as a 1.
Just a thought: should we allow this configuration to exist as content? if suppose that would treat ALL node link report configuration as content?
swirtSJW
commented
4 years ago @kevwalsh We could exclude just that one field, or a few fields from being part of the config. I am not a big fan of having unique exceptions... but I can also see the speed benefit of it. I do think there is benefit in actually checking the link out more deeply. Like in this case, Rachel says the link works, but didn't catch that it actually redirects from https://access.va.gov/accessva/?cspSelectFor=mass to https://eauth.va.gov/accessva/?cspSelectFor=mass
In looking deeper that system is blocking header only requests that are used in link checking. It is returning a 405 response to our request.
swirtSJW
commented
4 years ago Investigated https://www.militaryonesource.mil/health-wellness/mental-health It too is denying a header only curl. I created this d.o issue that would resolve them both. https://www.drupal.org/project/node_link_report/issues/3118060
swirtSJW
commented
4 years ago I just pushed up a fix for this https://www.drupal.org/project/node_link_report/issues/3118060 and triggered a release https://www.drupal.org/project/node_link_report/releases/8.x-1.13
Describe the defect A clear and concise description of what the bug is.
To Reproduce Steps to reproduce the behavior:
Go to /node/37
See broken link reported for VA appointment portal
Go to prod.cms.va.gov/health-care/health-needs-conditions/mental-health.
See broken link for Military OneSource
Expected behavior These reports should not be reported as broken.
Screenshots If applicable, add screenshots to help explain your problem.