Reduce "Parent Link" dropdown on VAMC Detail Pages based on Section

[davidmpickett]

Describe the defect

As a CMS editor assigned to multiple sections, I need to properly place VAMC Detail Pages into the appropriate spot in the menu hierarchy.

However, the drop-down menu for Parent Link under Menu Settings loads every single menu item from every VAMC system in sections I'm assigned to, so I can not tell at a glance if I am assigning a page to the correct menu. I may accidentally place it under the correct parent (e.g. Programs) but the wrong grandparent (e.g. VA Minneapolis).

To Reproduce

Steps to reproduce the behavior:

1. Go to https://staging.cms.va.gov/
2. Log in as Jackie.Stevenson@va.gov
3. Click VA St Cloud health care under section
4. Set Content Type to VAMC Detail Page
5. Click Apply
6. Edit any VAMC Detail Page (e.g. Yellow Pages edition 2)
7. In the right hand column go down to the Menu Settings and use the Parent link drop-down
8. See "menu of doom"

---

Additional example

Drupal Admins (like the help deskers) have to confront an even larger menu of doom when assigning new VAMC facilities to the appropriate place in the system menu. Ideally fixing this for VAMC Detail Pages would fix it for VAMC Facilities.

AC / Expected behavior

• [ ] I expect that the Parent Link dropdown will only show me the menu items for the VAMC system set in Section (field_administration) so I can't accidentally put it in the wrong system
• [ ] I expect any existing menu parent section has to be preserved
• [ ] If a Section has not been set yet, I expect that the Parent Link dropdown should be disabled (unless that significantly increases the size of this effort)

[davidmpickett]

May or may not be similar to #11069

[JayDarnell]

11069 does have some similarities. In that instance we didn't remove the option to select a bad choice up front, we merely throw an error if an invalid combination was selected. For this issue I believe our goal is to narrow down the available parent link options based on the section selected before the editor can make a bad selection. We would need a javascript solution for this to work on the fly. It would need to be smart enough to allow the user to change their mind.

It may need to start by grabbing the contents of the select list on page load and storing it, then removing anything from the list not under the matched item, then updating if the user changes their mind and chooses another section.

[JayDarnell]

@swirtSJW I'd like to discuss this with you at some point.

[davidmpickett]

Originally raised here: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/5471

[davidmpickett]

Not sure if any part of the solution for Lovell can be reused here https://github.com/department-of-veterans-affairs/va.gov-cms/issues/12303

[kmariepat-cityfriends]

You can't see which system you are under when you are looking at this list, example user is in description. Updates for admins who are viewing as well

[jilladams]

From refinement:

• DaveC request: verify how many users are impacted by this issue, before we take it on. In general: want to be able to demonstrate value based on # of users affected.
  • Data will be determined from CMS user data rather than Domo etc
  • Helpdesk impact / admin impact is clear, but: if only for a minimal number of users, may not be prioritized.
• Is this problem limited to VAMCs or bc of access to multiple sections? Both, but a bigger problem for VAMCs because those are the longer menus and have the most interaction with menus.
• Lovell quirk: need to confirm if Section editor > appearance in the front-end affects how we solve this

[kmariepat-cityfriends]

this should be completed alongside, based on the solution: #12884

[Agile6MSkinner]

@davidmpickett Do you think an engineer would be able to action this or is this more of an exploratory ticket?

[davidmpickett]

@Agile6MSkinner I just refined this to be clearer and actionable. Would still need a review from Drupal engineer before picking up.