Discovery around parentheses in phone numbers in Vet Center Operating Status More Info

[dsinla]

Describe the defect

Phone numbers in the operating status "more info" field for Vet Centers, appearing on the locations page, may not recognize phone numbers using parentheses so they aren't being formatted correctly.

From @mmiddaugh, original https://dsva.slack.com/archives/C0FQSS30V/p1670535690302759

When a phone number is entered with hyphens, the number is correctly rendered as a link:

When the phone number is entered with parentheses, the number is not rendered as a link:

Engineering notes

See this regex that matches phone numbers. This will not match the (xxx) xxx-xxxx version anywhere this is used. So, what we need to find:

• Is this same widget used in all Operating Status cases? If so, the same issue will exist in all cases. If not, we need to see if this is repeated anywhere.
• Should the parentheses pattern be acceptable? If so, we need to come up with a new regex. If not, we need to document somewhere, likely, that the parentheses format is not allowed.

To Reproduce

1. Go to a Vet Center - Outstation page, for instance: https://prod.cms.va.gov/la-crosse-vet-center/wausau-vet-center-outstation
2. Enter a phone number with hypens
3. See the number rendered correctly as a link on the Locations page
4. Enter a phone number with parenthesis
5. See the number rendered incorrectly - no link - on the Locations page

AC / Expected behavior

• [ ] The current behavior, and the desired behavior, is clearly understood and documented in this issue
• [ ] Determine if this behavior occurs across all Operating Status More Info for VAMCs (and VBA?)
• [ ] If this is a defect to be remedied, new ticket(s) is created for the fix. PERHAPS IMPLEMENT AS PART OF THIS TICKET?

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here. Reach out to the Product Managers to determine if it should be escalated as critical (prevents users from accomplishing their work with no known workaround and needs to be addressed within 2 business days).

Desktop (please complete the following information if relevant, or delete)

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Labels

(You can delete this section once it's complete)

• [x] Issue type (red) (defaults to "Defect")
• [ ] CMS subsystem (green)
• [ ] CMS practice area (blue)
• [x] CMS workstream (orange) (not needed for bug tickets)
• [ ] CMS-supported product (black)

CMS Team

Please check the team(s) that will do this work.

• [ ] Program
• [ ] Platform CMS Team
• [ ] Sitewide Crew
• [ ] ⭐️ Sitewide CMS
• [ ] ⭐️ Public Websites
• [x] ⭐️ Facilities
• [ ] ⭐️ User support

[mmiddaugh]

@dsinla adding these steps to reproduce for clarity

1. Go to a Vet Center - Outstation or Community access point page Examples:
   • https://prod.cms.va.gov/la-crosse-vet-center/wausau-vet-center-outstation
   • https://prod.cms.va.gov/la-crosse-vet-center/community-access-point/la-crosse-vet-center-osseo
2. Click "Edit"
3. Find the operating status box and enter a phone number formatted as (123) 456-7890 into the "operating status more info" field
4. Enter a revision log message and save as draft
5. Return to the dashboard by clicking on the Vet Center name in the breadcrumb (i.e., Home > La Crosse Vet Center)
6. Click "View" in the Locations page block on the Dashboard.
7. Click the blue "Preview" button in the top right corner
8. Scroll down to the relevant location on the preview Locations page
9. Open the expandable operating status display
10. Observe the phone number is not wrapped to be actionable on mobile or with assistive tech
11. Return to the edit screen for the location and repeat the process, editing the number by replacing the parentheses with hyphens (i.e., 123-456-7890)
12. Enter a revision log message and save as draft
13. Return to the dashboard by clicking on the Vet Center name in the breadcrumb (i.e., Home > La Crosse Vet Center)
14. Click " View" in the Locations page block on the Dashboard.
15. Click the blue "Preview button in the top right corner"
16. Scroll down to the relevant location
17. Open the expandable operating status display
18. Observe the phone number is now actionable

Suggest testing with other versions, such as

• 123.456.7890 (periods to separate segments)
• 123 456 7890 (spaces to separate segments)
• 1234567890 (no separation between segments)

[maxx1128]

My estimate: 5

Regexes are tricky, and regexes for content made by users on the CMS can get even tougher. This includes getting a flexible enough regex that is still accurate and correctly formatting the phone numbers in the same way.

[JayDarnell]

I would also estimate this with a 5. I believe we have some existing scripts we have used to manipulate phone data in the past but a 5 is a nice safe estimate in case we have to script this from scratch.

[kmariepat-cityfriends]

Next steps: we need to define requirements for this

[kmariepat-cityfriends]

the scope would be to define the desired behavior for all phone numbers