Make facility directions links consistent

swirtSJW commented 1 year ago

Describe the defect

On VAMC Facilities and Vet Centers, the links to directions are not the same

The link on the get directions text is missing address line 2 The link on the map is being properly created and includes address line 2

To Reproduce

Steps to reproduce the behavior:

Go to 'https://www.va.gov/des-moines-vet-center/'
Inspect the href on the "Directions (Google Maps)" and notice that it does NOT include the "suite 115" which comes from address:line_2
Inspect the href on the map image and notice that it DOES include the "suite 115" which comes from address:line_2

AC / Expected behavior

[ ] Both links should be identical and include address line2,

Desktop (please complete the following information if relevant, or delete)

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Labels

(You can delete this section once it's complete)

[x] Issue type (red) (defaults to "Defect")
[ ] CMS subsystem (green)
[ ] CMS practice area (blue)
[x] CMS workstream (orange) (not needed for bug tickets)
[ ] CMS-supported product (black)

CMS Team

Please check the team(s) that will do this work.

[ ] Program
[ ] Platform CMS Team
[ ] Sitewide Crew
[ ] ⭐️ Sitewide CMS
[ ] ⭐️ Public Websites
[ ] ⭐️ Facilities
[ ] ⭐️ User support

swirtSJW commented 1 year ago

This defect is unrelated to https://github.com/department-of-veterans-affairs/va.gov-cms/issues/11496 but surfaced during that investigation.

maxx1128 commented 1 year ago

I would estimate this as 1-2, the fix is likely something simple that's related to adding the second address line to the first Google Maps URL. If the logic that creates both links is different or more complicated, then I would bump it to a 2.

department-of-veterans-affairs / va.gov-cms