search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 70 forks source link

Events listing pagination and sorting is broken #1220

Closed kevwalsh closed 4 years ago

kevwalsh commented 4 years ago

Describe the defect Events pagination is whacked

Event sorting is all over the place for this one https://staging.va.gov/outreach-and-events/events/ it seems to be date ASC on each page, but not across all 3 pages.

Three pages exist here, but there should only be one: https://staging.va.gov/pittsburgh-health-care/events/

To Reproduce Steps to reproduce the behavior:

  1. Go to above URLs and click around

Expected behavior A clear and concise description of what you expected to happen.

Screenshots VA_Pittsburgh_Health_Care___Events___Veterans_Affairs.jpg

kevwalsh commented 4 years ago

i noticed that /news-releases sorting is borked too.

ethanteague commented 4 years ago

PR: https://github.com/department-of-veterans-affairs/vets-website/pull/11926

kevwalsh commented 4 years ago

@ethanteague can you get this up on a devshop PR environment for QA?

ElijahLynn commented 4 years ago

I just built this in CI at http://vacms1220.demo.ci.cms.va.gov/ and the FE build is failing with:

Step 25 start: Build Webpack assets Browserslist: caniuse-lite is outdated. Please run next command yarn upgrade

/var/aegir/projects/demo/vacms1220/docroot/vendor/va-gov/web/src/site/stages/build/webpack/index.js:43 if (err) throw err; image

More logs here > http://devshop.cms.va.gov/node/16120

Is lando composer va:web:build working locally for you?

ElijahLynn commented 4 years ago

Actually, here are the mo betta logs:

ERROR in ./src/platform/utilities/feature-toggles/helpers.js Module not found: Error: Can't resolve 'js-cookie' in '/var/aegir/projects/demo/vacms1220/docroot/vendor/va-gov/web/src/platform/utilities/feature-toggles' @ ./src/platform/utilities/feature-toggles/helpers.js 1:0-32 11:20-27 12:2-9 @ ./src/platform/utilities/feature-toggles/flipper-client.js @ ./src/platform/utilities/feature-toggles/index.jsx @ ./src/platform/startup/index.js @ ./src/applications/burials/burials-entry.jsx

ERROR in ./src/applications/caregivers/config/form.js Module not found: Error: Can't resolve 'vets-json-schema/dist/10-10CG-schema.json' in '/var/aegir/projects/demo/vacms1220/docroot/vendor/va-gov/web/src/applications/caregivers/config' @ ./src/applications/caregivers/config/form.js 9:0-67 22:24-34 23:28-38 32:28-38 92:9-19 128:117-127 177:130-140 200:606-616 216:606-616 @ ./src/applications/caregivers/routes.jsx @ ./src/applications/caregivers/app-entry.jsx

ERROR in ./src/applications/caregivers/definitions/caregiverUI.js Module not found: Error: Can't resolve 'vets-json-schema/dist/10-10CG-schema.json' in '/var/aegir/projects/demo/vacms1220/docroot/vendor/va-gov/web/src/applications/caregivers/definitions'

ethanteague commented 4 years ago

@ElijahLynn A new dependency was added to src/platform/utilities/feature-toggles/helpers.js so yarn install step needs to be added to the build process for it to be added to node_modules I would add, but I don't think I can add a pr to the demo environments on devshop? Anyway, we need something like

        "va:web:server": [
            "cd web && yarn install && yarn build"
        ],

in composer.json

ElijahLynn commented 4 years ago

Thanks, so I thought the Rebuild Environment task that rebuilds these DEMO ENVs ran yarn install but it doesn't, only the initial ENV creation does that, which runs on master the first time. I am adding it now in #1276.

ElijahLynn commented 4 years ago

K, #1276 is done now. Here are the ENVs.

  1. http://vacms1220.web.demo.ci.cms.va.gov/
  2. http://vacms1220.demo.ci.cms.va.gov/
  3. http://devshop.cms.va.gov/hosting/c/vacms1220.demo.ci.cms.va.gov