department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Discovery: Drupal translations editorial permissions #12235

Closed EWashb closed 1 year ago

EWashb commented 1 year ago

Description

As we explore Drupal OOTB translation options, it is essential to understand how the permissions/access will work for our editors. This will help us determine the level of change management and the approach for the editorial experience.

What we would like to know:

Acceptance Criteria

timcosgrove commented 1 year ago

The short answer is:

EWashb commented 1 year ago

@davidconlon Tim's feedback here is interesting on the role of translation permissions. I wanted to loop you in.

timcosgrove commented 1 year ago

To be clearer, 'viewing translations' is just, the user is able to see translated content. There is also a 'view published content' permission, which should be granted to all users, for just seeing any Drupal content. Denying 'view translations' could also have unintended consequences for Content Build, for referencing other nodes from another node, etc.

In terms of what types of permissions, we should distinguish between Drupal translation and Translation Management (TMGMT), which is an add-on functionality.

TMGMT is how we would create XLIFF files for translating a given set of content, connecting to the Translation Management System if one exists (I understand we're planning to do manual email of files, which I have thoughts about), and then reviewing the incoming translations on XLIFF files prior to accepting them into the system. Translation management should be its own role, though a reminder that a given user can be assigned multiple roles, so this is not really a "user type". Nevertheless, translation management is a reasonably complex task that should be restricted to a few people who are trained in how to use the system.

'Translation editing' on the other hand is just that - taking existing translations and making modifications to them. We can also distinguish between creating new translations and editing existing ones, so for example we can require that all translations be initially created by TMGMT processes, but then small modifications made later.

I recommend Translation editing permission not be restricted to admins and the translation management role, because there will be cases where an editor might just need to correct a small detail of say a Spanish translation and shouldn't have to go through a Support Request cycle for that. OTOH, I also understand exposing that to the average editor might be both dangerous and confusing.

These are things we can and will need to discuss. There are many UX, data integrity, and operational flow considerations. Nothing crazy, but things we'll want to discuss and make intentional decisions about.

timcosgrove commented 1 year ago

Translation management perms:

Translation perms:

EWashb commented 1 year ago

This was completed as part of #12186