Events: Inconsistent breadcrumb capitalization

[ryguyk]

Status

[2024-07-22] [Fran] Jill mentioned in Product Syn meeting today that this may be a DS Team issue to solve/provide guidance. Moving out of the Next Refinement and assigned to me for follow up.

What's going on?

There is code that generates breadcrumbs from a URL. This breadcrumb generation capitalizes only the first letter in each of the breadcrumbs. So, we end up with things like "Lovell federal va health care" instead of "Lovell Federal VA health care".

But there is some nuance. We don't see this on every page. Here are some pages where we do see it:

Event Detail Pages

This problem will exist on (almost) all event-detail pages, because this code makes it such that all event detail nodes have their breadcrumbs generated from the URL, even if the breadcrumb is already present.

https://www.va.gov/central-iowa-health-care/events/52266/

https://www.va.gov/minneapolis-health-care/events/48210/

In the above examples, we see that only the first letter is capitalized, which is clearly problematic in the first case because "iowa" is not capitalized. In both the Central Iowa and Minneapolis examples, note that the breadcrumb does not include "VA" as a prefix. They should behave like this Pittsburgh example:

https://www.va.gov/pittsburgh-health-care/events/52605/

In fact, ALL event detail pages will have this problem except events at Pittsburgh VA. This is due to seemingly very old code that specifically checks for Pittsburgh VA and handles as an exception. I imagine this is a remnant of the time when Pittsburgh was the first VAMC to be modernized.

How to fix?

It is likely the case that Max's code negates the need for any specific processing for event nodes. Event-detail pages should not need a specific call to this breadcrumb-generation function since the newer code is conditionally calling that function for all content that does not have a breadcrumb passed over from Drupal. If the event-specific call is removed, the problem would be fixed for event-detail pages because they are now coming over from Drupal with a breadcrumb object, so this generation function would not be called.

[mmiddaugh]

Related: #12125: Vet Center Breadcrumbs not matching H1

[FranECross]

Jill mentioned in Product Syn meeting today that this may be a DS Team issue to solve/provide guidance. Moving out of the Next Refinement and assigned to me for follow up.

[mmiddaugh]

relevant issue: #2095 New va-breadcrumbs support

[laflannery]

This is not resolved with V3 as the processing of the crumbs is separate. However this is resolved in the AP templates. They still need to upgrade to v3 but this correct capitalization should still be resolved when they do:

• Central Iowa:
• Minneapolis:

[aklausmeier]

DST breadcrumb support ticket is complete and this capitalization issue persists. This should be unblocked and may need to be a spike if we want to fix in content build. It appears Next build did not inherit the code that is causing this issue.

@FranECross @mmiddaugh