department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

Change all select list fields from `Select a value` to `- Select -` #1281

Closed kevwalsh closed 2 years ago

kevwalsh commented 4 years ago

User Story or Problem Statement

We want consistent drop down behavior across the site.

Acceptance Criteria

Implementation steps

netboss commented 2 years ago

@kevwalsh @rachel-kauff Here is a list of all content types with a "- Select a value -" select list and the form URL. I also added a note with details about where in the form this is showing (I also took screen shots of almost all of them, but since this is a big list am not including the screen shots):

Please let me know of anything else.

kevwalsh commented 2 years ago

Thank you! If you have screenshots, do you want to just dump them in a google drive folder and link to it form here? I think we need to wait for Rachel to get back on Tuesday Feb 23 to validate that her spec from two years ago is still something we want to go with. Maybe a couple screenshots here would be good, too. but not all.

netboss commented 2 years ago

@kevwalsh Here are some of the screen shots: Benefits Detail Page: Create-Benefits-Detail-Page

Benefits Hub Landing Page: Create-Benefits-Hub-Landing-Page

CMS Knowledge Base Article: Create-CMS-Knowledge-Base-Article

Campaign Landing Page: Create-Campaign-Landing-Page Create-Campaign-Landing-Page_What-you-can-do-promos

Checklist: Create-Checklist Create-Checklist_Article-categories

Event: Create-Event Create-Event_Where-should-the-event-be-listed

Events List: Create-Events-List

These are the ones I took, but basically the "- Select a value -" string shows in the same places in the forms.

rachel-kauff commented 2 years ago

@netboss Nice work! Thanks for doing all that auditing. I think we're good to go ahead and change all the Select a value fields to Select

netboss commented 2 years ago

It was decided to keep using the "- Select a value -" due to accessibility concerns. Closing. See more details in discussions here https://dsva.slack.com/archives/CT4GZBM8F/p1645564475376399 and here https://civicactions.slack.com/archives/CCX8C4MCY/p1645565416075939 -- ccing @kevwalsh @rachel-kauff @swirtSJW