department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Accessibility Issue in Media content pagination #12912

Open ndouglas opened 1 year ago

ndouglas commented 1 year ago

Description

Still an issue in D10

Seeing this Axe error:

Screenshot 2023-03-09 at 2 45 05 PM

for this item:

Screenshot 2023-03-09 at 2 44 36 PM

on /admin/content/media.

Todos

Team

Please check the team(s) that will do this work.

Previous Team Points

3

laflannery commented 1 year ago

I looked into this and this is done pretty much everywhere as a very established pattern (Drupal, VA, USWDS). I have a proposed solution but I'm running it by the other a11y folks just because I wanted some other eyes.

@ndouglas For now, if this is blocking you or others from completing tests or merging code I do not have an issue with you writing an ignore in for this since I have this documented and as it's upstream might take a bit to get resolved. If you do, can you note it in here so we can remember to remove it later?

ndouglas commented 1 year ago

Yeah, that works for me. Thank you!

laflannery commented 1 year ago

Core issue: https://www.drupal.org/project/drupal/issues/3348552

productmike commented 1 year ago

@tonytaylor @edmund-dunn If able to a deeper look at the patch and update story point as necessary. F/up 7/5

productmike commented 1 year ago

@edmund-dunn @tonytaylor Can y'all include this in your pre-finement discussions prior to next week's refinement session?

cc: @laflannery @BerniXiongA6

ndouglas commented 1 year ago

Edmund suggests this should be prioritized post-D10.

srancour commented 6 months ago

Still an issue and should be addressed.