Remove btsss_login_widget feature flag after launch

[jilladams]

Description

12591 created a flipper, btsss_login_widget for the purposes of testing / launch.

When BTSSS widget is launched, this flipper can be deprecated.

User story

Describe the audience/user, enhancement or fix, and value / outcome desired.

AS A(N) engineer I WANT to reduce technical debt and the number of feature flags in play SO THAT the build system stays optimized.

(This story is speaking for Plat where they care about the fact of Flippers, but I can't speak technically to why.)

Order of operations

• Remove from vets-website first (to show widget regardless of flipper, and remove flipper references)
• Remove from vets-api after

Acceptance criteria

• [x] I expect that the btsss_login_widget is no longer present in vets-api code or flipper UI
• [ ] I expect that the BTSSS login widget still appears correctly in prod

Team

Please check the team(s) that will do this work.

• [ ] CMS Team
• [X] Public Websites
• [ ] Facilities
• [ ] User support

[jilladams]

3 assumes this could be a good ramp up task for Randi.

[randimays]

Validation complete for staging and production for vets-website and vets-api changes. Waiting on the flipper dashboard to catch up (and remove the flag) as final validation.

[randimays]

Still waiting on flipper dashboard to catch up and remove the flag here: https://api.va.gov/flipper/features Not sure what the standard waiting period is, but it looks like this ticket won't close in time for the new sprint.

[jilladams]

Totally fine. If we don't see this ship in a day or two, may be worth a #vfs-platform-support ask to understand timing and if we hit all the necessary boxes for it to wrap.

[randimays]

I made a Platform Support ticket to see what's happening with the flipper dashboard. Waiting for a response.

[randimays]

Screenshots for prod validation

Logged In

Not Logged In

[randimays]

@wesrowe @jilladams Turns out there is a job that automatically prunes unused toggles from the database (thus removing them from Flipper Admin) but it was also removing toggles that are still in use, so they disabled the job temporarily. That is why the toggle is still appearing in Flipper Admin. Platform confirmed we've done everything we needed to do to remove the toggle. @wesrowe anything else you want to check while this is in PO review, or are we ready to close?

[randimays]

Support ticket and Slack thread for reference: https://github.com/department-of-veterans-affairs/va.gov-team/issues/57465 https://dsva.slack.com/archives/CBU0KDSB1/p1682527701785429

[wesrowe]

Since this is Platform's problem and they have a process around it, I think we can close.

[jilladams]

INTERESTING. I did not know that the pruning job was doing this exact work. @randimays did Platform indicate they would run the pruning job? Or now is it expected behavior that removed flags will appear in the UI? Do we know what happens if we try to modify the flag, now that it doesn't exist?

[randimays]

@jilladams Platform said in the support ticket that they would try to get it manually removed, but not that they would run the job. I think it's disabled until they can dig deeper. For now the expected behavior is that removed flags will still appear in the UI until that job is fixed. Since there is no vets-api mapping for the flag anymore, and no code in the UI to respond to it, changing it in Flipper Admin shouldn't do anything.