department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 68 forks source link

Remove va_home_preview_modal feature flag after launch #13184

Closed jilladams closed 1 year ago

jilladams commented 1 year ago

Description

When homepage is hard launched, this flipper can be deprecated.

User story

Describe the audience/user, enhancement or fix, and value / outcome desired.

AS A(N) engineer I WANT to reduce technical debt and the number of feature flags in play SO THAT the build system stays optimized.

(This story is speaking for Plat where they care about the fact of Flippers, but I can't speak technically to why.)

Order of operations

Acceptance criteria

Team

Please check the team(s) that will do this work.

jilladams commented 1 year ago

2, unless we change scope unless we change scope to handle more tech debt.

randimays commented 1 year ago

Marking as complete; changes have been deployed to production and modal does not show up at / or /new-home-page. As stated above, flipper still appears in the Flipper Admin because the job to clean up unused flippers is temporarily turned off due to bugs.