Closed omahane closed 1 year ago
Looks good. Only minor concern is about the field name for non VA location website. answered in slack
Based on ^^ I think we want to re-use "field_link" as opposed to "field_non_va_location_url"
@omahane Wondering if field_nca_classification ought to be a select list that we can normalize to in the migration. Are there just two classifications in the data?
Per Adam, it's possible new classifications could be added on the CDW side and would get passed on through: https://dsva.slack.com/archives/CJ162GDDJ/p1682086392200209?thread_ts=1681847189.858779&cid=CJ162GDDJ
We also need timezone.
We also need timezone.
I couldn't find an already existing field, so I added this when I created this ticket.
Ask lighthouse team on Monday 5/1 about any existing standard on timezone
Ask lighthouse team on Monday 5/1 about any existing standard on timezone
After looking at the data, it appears that they use the TZ identifier as described here: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
After deduping the ones in the sandbox, I found this list
time_zone": "America/Chicago",
time_zone": "America/New_York",
time_zone": "America/Detroit",
time_zone": "America/Indiana/Indianapolis",
time_zone": "Asia/Seoul",
time_zone": "Europe/Berlin",
time_zone": "America/Kentucky/Louisville",
time_zone": "America/Menominee",
time_zone": "America/Denver",
time_zone": "America/Los_Angeles",
time_zone": "America/Phoenix",
time_zone": "America/Boise",
time_zone": "America/Puerto_Rico",
time_zone": "America/St_Thomas",
time_zone": "Asia/Manila",
time_zone": "Pacific/Honolulu",
time_zone": "Pacific/Guam",
time_zone": "America/Anchorage",
time_zone": "America/Sitka",
time_zone": "America/North_Dakota/New_Salem",
time_zone": "Pacific/Saipan",
time_zone": "America/Metlakatla",
time_zone": "America/Indiana/Vincennes",
time_zone": "America/Juneau",
time_zone": "Pacific/Pago_Pago",
@swirtSJW I was going to pick this up, but I realized that we were talking about the Timezone and hadn't determined if we were making this field or using the contrib module for it.
@swirtSJW I'm wondering what the "test on migration" should look like or do?
User Story or Problem Statement
Per #13123, there are fields that are in the Facilities API that are not in the CMS.
Acceptance Criteria
I expect a test on the migration is addedOn review: Migrations are hard to test bc you test after it runs. This is adding new data to an existing migration, and we have logical points to verify success already. Removing AC.Questions for refinement
Implementation steps