Remove facilities_locator_mobile_covid_online_scheduling Flipper

[kmariepat-cityfriends]

va-11588-remove-mobile-covid-scheduling-flipper

Description

(added on 1/2/2024 based on #11588)

As part of a Flipper audit, @maxx1128 did a quick search through the code repos for the flipper facilities_locator_mobile_covid_online_scheduling (and also the camel case spelling, (facilitiesLocatorMobileCovidOnlineScheduling`) and found it had actually already been removed by our team last November.

However, there are still a few references to the feature flag in vets-api, mostly in some test files. Since the flipper has been deleted, the references are now dead code. But once those are gone then this flipper should be 100% gone from the codebase. They're easy to remove so @maxx1128 opened a pull request to do that to wrap this flipper up (branch with the dead code removed: va-11588-remove-mobile-covid-scheduling-flipper).

This issue seems to have been created to actually merge that PR.

[mmiddaugh]

@jilladams - this issue had no description outside of the first line above so I filled in some details based on the comments in #11588 - can you take a look at your convenience and see if it looks correct?

I'm not sure why this wasn't just merged to begin with - or if it is still relevant, tbh.

[jilladams]

Great question - I'm not certain why we didn't go ahead with the PR.

When I check vets-api for that branch, it doesn't appear -- not certain if it got pushed as a different name or not: https://github.com/department-of-veterans-affairs/vets-api/branches/all?query=va-11588-remove-mobile-covid-scheduling-flipper&lastTab=overview

When I check vets-api for references to the feature flag, they still do exist:

Searching 8482 files for "facilities_locator_mobile_covid_online_scheduling"

~/code/vets-api/modules/facilities_api/app/controllers/facilities_api/v1/va_controller.rb:
   12        api_results = api.get_facilities(lighthouse_params)
   13  
   14:       if Flipper.enabled?(:facilities_locator_mobile_covid_online_scheduling) && covid_mobile_params?
   15          api_results.each do |api_result|
   16            api_result.tmp_covid_online_scheduling = mobile_api_get_by_id(api_result.id)

~/code/vets-api/modules/facilities_api/spec/requests/facilities_api/v1/va_request_spec.rb:
  282  
  283          before do
  284:           Flipper.enable('facilities_locator_mobile_covid_online_scheduling', flipper)
  285            get '/facilities_api/v1/va', params:
  286          end
  287  
  288:         context 'facilities_locator_mobile_covid_online_scheduling enabled' do
  289            let(:flipper) { true }
  290  
  ...
  313          end
  314  
  315:         context 'facilities_locator_mobile_covid_online_scheduling disabled' do
  316            let(:flipper) { false }
  317  

4 matches across 2 files

So ticket is still relevant, and @maxx1128 may be able to resurrect the branch / finish this out, when we decide to prioritize it.