department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

Content IA and Accessibility: decide how single VAMC + Outreach events should be treated #13532

Closed kmariepat-cityfriends closed 1 year ago

kmariepat-cityfriends commented 1 year ago

Background

How many FE pages should get created for Events published to more than one Event List & how should breadcrumbs be handled?

Option 1 - Multiple Pages (one per listing page appearance)

RULED OUT.

Option 2 - Single Page, multiple paths

Option 2A - Single Page, single path

Option 3 - Single Page all in Outreach Events, always

All event pages get built at va.gov/outreach-and-events/events/#####/ regardless of what listing page(s) they appear on. Breadcrumbs are either:

Option 4

How long should we keep Events published after they have ended?

Open Questions:

ACs

kmariepat-cityfriends commented 1 year ago

@davidmpickett for a first pass draft of writing out option 1 and 2 referenced above

swirtSJW commented 1 year ago

I added a third option to kick around.

kmariepat-cityfriends commented 1 year ago

Context notes:

kmariepat-cityfriends commented 1 year ago

Context notes:

mmiddaugh commented 1 year ago

@jilladams is this still valid? If so, should it belong to Facilities or Public Websites?

jilladams commented 1 year ago

Chatted with Facilities re: SME for the previous conversations. Couple notes from that:

  1. We will need to take this to CAIA, going to file an intake ticket with them to get it on the radar, but we need to settle on our proposal before they engage.
  2. Michelle flagged: Breadcrumbs have inconsistent behavior (News releases, stories, events) between Listings & Single pages. This is known problem for Mikki, and she may be inclined to evaluate the bigger picture when we discuss. We'll need to manage expectations / scope there.
  3. Dave Pickett is happy to discuss philosophically if needed, and Steve helped put together the proposals in ticket body, so @dsasser feel free to reach out to either or both if it would help think through things.
jilladams commented 1 year ago

Bigger picture on breadcrumbs history: Standardize Breadcrumbs for events, news releases and stories #10030 [DISCOVERY] Intended breadcrumb behavior (VAMC)#13902

jilladams commented 1 year ago

@laflannery hi, FYI: We need to pull you in here. Context:

Daniel / Christia have a CMS solution working to add a checkbox to the Events form, that allows an Editor to select an Event listing from the dropdown, and select a checkbox to publish that same event to the Outreach events calendar. DaveC would like this to ship in time for Veterans Day if at all possible, but we have hit breadcrumb/URL issues that need your input.

Screenshot 2023-10-05 at 9 04 44 AM

Currently in the implementation:

Our team needs to:

Where to see this in action:
Tugboat: https://tugboat.vfs.va.gov/651ddd6e2d3036648dec2077 CMS: https://cms-thu3raipnqtrntaczkhou6vtskp73ajc.demo.cms.va.gov/ FE - Alaska VAMC event (Fri Oct. 6): https://web-thu3raipnqtrntaczkhou6vtskp73ajc.demo.cms.va.gov/alaska-health-care/events/ FE - Lovell event (Sat Oct 7): VA.gov URL: https://web-thu3raipnqtrntaczkhou6vtskp73ajc.demo.cms.va.gov/lovell-federal-health-care/events/61946 FE - Outreach events cal: https://web-thu3raipnqtrntaczkhou6vtskp73ajc.demo.cms.va.gov/outreach-and-events/events/

jilladams commented 1 year ago

(I just requested a content build on that tugboat, so may be ~30-45mins before FE is available again.)

jilladams commented 1 year ago

Laura's a11y notes:

wesrowe commented 1 year ago

CAIA intake ticket to review our proposed breadcrumbs.

jilladams commented 1 year ago

@dsasser Updated ticket body to record what is happening today in the implementation in progress, as Option 2A. When you have a chance, give that a onceover, and confirm it's correct?

dsasser commented 1 year ago

@dsasser Updated ticket body to record what is happening today in the implementation in progress, as Option 2A. When you have a chance, give that a onceover, and confirm it's correct?

2A looks correct, thanks for adding that.

laflannery commented 1 year ago

@jilladams I had a thought early this morning and the tugboat isn't loading so I can't check the behavior - what happens to the "See all events" links at the bottom of the event pages? Do those follow the breadcrumbs? For example if I'm on the Outreach listing, then go to the Alaska event from above with the VAMC breadcrumbs and click on "See all events" does that take me to the VAMC events listing? I don't think my conclusion is going to change but I just want to be sure I know what's going to happen here.

dsasser commented 1 year ago

@laflannery

what happens to the "See all events" links at the bottom of the event pages? Do those follow the breadcrumbs?

The 'see more events' link does in fact follow the breadcrumb. This can be seen from the code snippet below, which uses the breadcrumb to build the link:

        <a
          class="vads-u-padding-bottom--3 vads-u-margin-top--1 vads-u-font-weight--bold"
          href="{{ entityUrl.breadcrumb | getValueFromArrayObjPath: index, 'url.path' }}"
          onclick="recordEvent({ event: 'nav-secondary-button-click' });">
          See more events
laflannery commented 1 year ago

Thanks @dsasser! I'm still good with everything just wanted to make sure

dsasser commented 1 year ago

Update

Without making any FE changes, the breadcrumb functionality aligns with option 2A

Option 2A Option 2A - Single Page, single path When a VAMC Event is added to the Outreach Event List, a single HTML page is generated and uses the canonical VAMC URL (e.g. va.gov/chicago-health-care/events/#####). Breadcrumbs will always point to the VAMC Events page, even if user has arrived at the Event page via the Outreach Events listing. Pro: The number of page objects created stays the same Pro: We avoid fragile breadcrumb solutions. A11y has signed off on the UX. Con: Only one set of breadcrumbs for the event, confusing user experience when coming from Outreach Events list. If there is a way to have multiple breadcrumbs would be fragile based on browser history Note: Same Lovell note as Option 2. ~~Con: Lovell is confused and needs add'l work to resolve, WIP~~ (resolved by setting the 'Section' to the appropriate facility. Tests were previously using arbitrary sections) Con: This will not work in the multi-VAMC / multi-Facility use case, when we get there. We will need to revisit breadcrumbs / paths, when multi-select is available.

We have support from Laura in regards to a11y. So with that, we are ready to take this to CAIA and pending that approval, proceeding to change management.

jilladams commented 1 year ago

@dsasser CAIA intake is filed: https://github.com/department-of-veterans-affairs/va.gov-team/issues/67025, and I created #15627 to track any follow up required from that discussion (it'll need to get refined once we've talked to CAIA). I vote this can close. Doing so.