I.L. FE: Add breadcrumbs

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.

https://prod.cms.va.gov

GNU General Public License v2.0

98 stars 69 forks source link

I.L. FE: Add breadcrumbs #13588

Closed wesrowe closed 1 year ago

wesrowe commented 1 year ago

Description

User story

AS A Veteran I WANT to see breadcrumbs at the top of the screen as in the designs SO THAT I can find my way back.

See epic for design files.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

[x] Mobile breadcrumb is as designed
[x] Desktop breadcrumb is as designed

wesrowe commented 1 year ago

hmm, didn't see these in staging for some reason

randimays commented 1 year ago

Adding a note here that our breadcrumbs design was updated in the Sketch file. Here's the related Slack thread: https://dsva.slack.com/archives/C52CL1PKQ/p1685647199332129

wesrowe commented 1 year ago

@randimays, Something odd happened with the continue/back buttons. I think I saw a thread about how they needed to stack. Anyway, got a weird result (firefox on mac):

wesrowe commented 1 year ago

I meant to say: breadcrumbs look good. Can close.

randimays commented 1 year ago

This was finished, but carrying over unexpectedly as the breadcrumbs implementation I used is not the correct one and I am about to put up a couple PRs to fix it.

randimays commented 1 year ago

Verified in staging; got the accessibility and design sign-off pre-merge as well.