Add "awaiting ticket" flag to Flagged Content view and all facility content types

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.

https://prod.cms.va.gov

GNU General Public License v2.0

97 stars 69 forks source link

Add "awaiting ticket" flag to Flagged Content view and all facility content types #13624

Open jilladams opened 1 year ago

jilladams commented 1 year ago

Description

Add a flag for "Github tickets created". This can/ will be used when reviewing the Flagged Content view to differentiate flags that are New / Removed / Changed flags that haven't been ticketed, from those that have been ticketed, but are not yet also flagged as "awaiting CSV / editor / redirect." The goal is to understand which are actually new flags that need to be addressed, vs. flag that are already logged/underway. (That's not clear today in CMS, without referencing Stef's Flagged Content sheet.)

ACs

[ ] I expect "awaiting ticket" flag is available on Flagged Content view
[ ] I expect that the awaiting ticket is added to a facility when a remove from source name change OR new facility flag
[ ] I expect that removing the flag from a facility will result in an appropriate message in the facility's revision log.
[ ] I expect any runbook that references the above flags are updated to be completed by @jilladams

jilladams commented 1 year ago

@swirtSJW can you add your thoughts re: not adding Github actions here?

jilladams commented 1 year ago

From 5/18 refinement: concerns around bulk actions are:

Can't think of a case where we would clear out a mass of flags without adding specific data to each.
Bulk Ops is handy but skips processes, such as flagging / de-flagging node will save messages to Revision log. Bulk Ops would not handle this the same way.

kmariepat-cityfriends commented 1 year ago

@kmariepat-cityfriends to give a @jilladams a heads up when this is prioritized in a sprint

swirtSJW commented 1 year ago

Implementation ~details~ thoughts: I mentioned in refinement that the auto flagging would need to be added in two locations.

the ones that happen on facility save. (new facility, name change)
the one that happens after the entire migration is run. (removed from source)

It occurs to me we might be able to catch all cases in flag entity save (hook/event). Then it could all be kept in one spot and act on adding the "awaiting ticket" flag when ever adding new, changed, removed from source. A flag is an entity so we should be able to tap into the entity save event.

Agile6MSkinner commented 2 months ago

@jilladams Is this still something we want to do?

jilladams commented 2 months ago

Definitely. It would be massively helpful for the Flagged Facilities workflow, if we could get it done.