VAMC System Spotlight content - Discrepancies between CMS and FE

[laflannery]

Description

When looking to determine a standard CMS Spotlight pattern, I found some discrepancies between the CMS fields used on the VAMC System content type in the CMS and what is actually displayed on the front end. We should investigate this further to determine the original intent, what should actually be happening and make any necessary updates to reduce confusion and ensure the CMS matches the FE.

Issues found

Title field

• There is a title field that is filled in with "In the spotlight at {VA system name}". This field looks like any other standard CMS field however when the editor makes changes to this field, those changes are not reflected on the front end on VA.gov
• If this field truly shouldn't be editable, we should remove it or disable it from the CMS

Link summary fields

• Each link teaser has a Link summary field. However, similar to the Title field, if an editor adds text into these summary field, it doesn't display on the front end.
• I think the reason this field is here might be because it's part of the Link teaser bundle (possibly not the right term) - it's all just packaged together as one think with the other Link fields.
• However, this is confusing for editors - what's in the CMS should be the same as what's display on the front end.

Number of Link teasers

• In the CMS I can add as many link teasers as I want, but regardless of how many I add, only the first 8 show on the front end.
• This is confusing to the editor and there should be some direction here. We should either put a limit on this in the CMS, to match the front end, or if there is a reason that the CMS should be more we should add some help text to explain why this is set up this way.

additional info from Michelle

• there is an existing issue to enforce the FE limit of 8 links in the editorial UI: Refactor field_related_links on VAMC system as maximum 8 normal link fields #7096
• details from Steve found in a duplicate (closed) issue (#8058)
  • FE template code
  • FE ticket that created this - department-of-veterans-affairs/content-build#728

Acceptance Criteria

• [ ]

Team

Please check the team(s) that will do this work.

• [ ] CMS Team
• [ ] Public Websites
• [x] Facilities
• [ ] User support

[davidmpickett]

Just to unpack the Matryoshka of Drupal entities at play here:

• The VAMC FE In the spotlight box is powered by the Common Links field on the VAMC System content type.
• The Common Links field (machine name: related_links) uses the List of link teasers paragraph type
• The List of link teasers paragraph type uses the Link teaser paragraph type for each item in the list
• Some of the feedback here applies to different levels of nested entities
  • The Link summary field is a part of the Link teaser paragraph type
  • The Title field is part of the List of link teasers paragraph type

However, while this ticket is about making the VAMC System CMS form match the FE VAMC In the spotlight box, we can't edit the nested parts where the issues are without affecting all other content types that also use those paragraph types.

• The "List of link teasers" paragraph type is used by 5 other content types, 2 of which are owned by Public Websites and 1 of which is owned by CMS platform

Kev made a ticket back in 2021 to move this to using an entirely new field. That is probably what would be worth reviewing as a possible path forward here