Closed mmiddaugh closed 1 year ago
Can we get the change we originally requested so we can fix this issue?
Do we know what they originally requested?
I discussed with Amanda. Her recommendation is to replace the existing Informational alert style with the Warning alert style, changing the color to Yellow and changing the icon to an exclamation point. This allows us to make it more visible while staying within the design system and established patterns.
@mmiddaugh That was the original design we took to Midpoint Review and was rejected by platform
https://github.com/department-of-veterans-affairs/va.gov-team/issues/46056
@davidmpickett Thank you for the contextual background on Midpoint Review, this confirms my only hesitation.
Also, noticed feedback in Midpoint suggested ensuring font size and styling is the same as what is shown in design system and we have room to improve as the current fonts in informational alert on the Lovell pages are much smaller. It's another solution that would require minimal effort to test.
If data supports moving forward, I would suggest design alternative solutions to test into with usability testing.
cc @mmiddaugh
Acceptance criteria has been updated to reflect Amanda's point about font size and styling.
In collaboration with VHA DM, we determined that we will measure the impact of the change by monitoring page traffic (based on percent of beneficiaries) and VSAT scores (benchmarked against Veteran data).
From planning: If Eli gets access, this is a good first task. If not, Max will own completion before end of sprint, and pair.
I have made the change locally, will open a PR with some direction from @maxx1128
Merged / deployed. Took a look cuz I'm curious, and verified in Prod, screenshots:
Closing! FYI @xiongjaneg . Congrats, Eli!
@jilladams @xiongjaneg It was brought to my attention that the alert style was updated to "warning" but the updates to fonts, size, styling were not brought into alignment with design system, link to design system in above Acceptance Criteria. What would be next steps to have this reopened and add AC that I review during staging?
One additional AC: Additional guidance that was shared with me today was from original staging collab cycle that is needed to close #54298
Change font weight of active link to 700 and end the tag before the space between beneficiary and >
cc: @laflannery
@aklausmeier I'll reopen and move to Facilities backlog. We have some work with VHA Digital Media on this topic, so this is timely. Thank you.
@aklausmeier @xiongjaneg @jilladams
There was a mention of the word active in the link. Should this be an Active link
?
https://design.va.gov/storybook/?path=/docs/components-va-link--active
Currently it's just an anchor tag. It would make sense if it is actually supposed to be an Active link instead though.
@eselkin Yes, it is an active link component with font-weight of 700.
@eselkin This "warning alert" should also mirror the heading and paragraph styles with font family, size and weights. shown here in Storybook https://design.va.gov/storybook/?path=/docs/components-va-alert--warning
(but with space between the link and the caret)
cc @xiongjaneg @jilladams @laflannery
@eselkin This "warning alert" should also mirror the heading and paragraph styles with font family, size and weights. shown here in Storybook https://design.va.gov/storybook/?path=/docs/components-va-alert--warning
(but with space between the link and the caret)
cc @xiongjaneg @jilladams @laflannery
Yep, I have a change in (still rebuilding) that I'll have you check out. It looks similar to your image above (an H2 for the text and an Active link -- with the animated arrow not underlined)... here's a screenshot:
It's interesting, nowhere on any template in content-build do we use a va-link component (let alone the active one).
This is great @eselkin
For reporting purposes:
Verified in prod: H2, Active link uses animated arrow not underlined, Amanda signed off at PR review. Closing!
Issue description
VHA DM received word from our Lovell colleagues that they are receiving complaints from Veterans regarding the dual-banner view:
This is a relatively new experience - time and familiarity may resolve this issue.
Analytics
Patient population numbers from January 2023 and were provided by the Lovell communication staff.
Lovell health care analytics June 21 - July 18, 2023
Open questions
I discussed with Amanda. Her recommendation is to replace the existing Informational alert style with the Warning alert style, changing the color to Yellow and changing the icon to an exclamation point. This allows us to make it more visible while staying within the design system and established patterns.
Acceptance criteria