department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
97 stars 69 forks source link

Move Facility related entity checks from FacilityOps into new Facility node class(es) #14563

Open swirtSJW opened 1 year ago

swirtSJW commented 1 year ago

Description

The new approach created by the CMS Platform Team in va_gov_content_types makes way for adding properties and methods to classes that extend the vaNode class.

This is a much better way to address some of the work that we have scattered in calls to FacilityOps. (easy to find and replace) FacilityOps should then remain the place for data like what content types are considered facilities.

Acceptance Criteria

swirtSJW commented 1 year ago

Please add your planning poker estimate with Zenhub @omahane

swirtSJW commented 1 year ago

@jilladams @xiongjaneg We don't really have an epic for "Aligning with CMS Platform Changes" but it might be a good idea.

jilladams commented 1 year ago

For now, I think we can use Technical Debt, and review that for urgency as new items pop up. (My takeaway from Scrum today.) Also noting that I flagged this topic with Berni, and Michelle is seeding with Erika, re: how CMS changes > Product changes comms work, when it starts with engineering, especially.