Closed stefaniefgray closed 1 year ago
Tagging @jilladams and @Dottisea
Ryan resolved a similar issue before moving to AP: Inconsistent displays for phone numbers within VAMC health service accordions #13705
I have confirmed through some local testing that the cause is the fieldPhoneNumber
field is empty (the below screenshot shows the raw data output from my local machine). The component only checks if the "Use the general facility phone number" checkbox has been clicked, but not if there's also a facility phone number that has been selected.
I think there are two approaches to fixing this:
fieldPhoneNumber
is mandatory, this is a CMS change. It either needs to be marked as required in the CMS or, if it already is, confirm it's being saved under the correct property name.fieldPhoneNumber
is not mandatory, this is a front-end change. The template needs to check for both the checkbox being checked and the phone number being present, otherwise, it skips showing the Main Phone section altogether.cc: @stefaniefgray @jilladams @Dottisea
@maxx1128 to connect with @swirtSJW @omahane async for plan.
@maxx1128 to connect with @swirtSJW @omahane async for plan.
I have our async Slack thread for the plan link here. cc: @jilladams
Thank you everyone! You rock @maxx1128 🎸
Will update original reporting editor in https://va-gov.atlassian.net/browse/VAHELP-6187 once resolved
This is not unique to this location. It can be observed on Pittsburgh's Register for care and Medical records pages.
For contrast: Eastern Kansas
@maxx1128 When the box is checked, to use the main facility number, that number does not live on the non-clinical service entity or on the Medical Records entity, it lives on the facility entity which ought to be in that data through the entity reference on the non-clinical entity in the query (or will need to be added)
The other option is to grab it from the full data object that should have all the facilities.
Assigning Eli to help finish out QA steps / discussion with Swirt for getting this PR merged.
PR: https://github.com/department-of-veterans-affairs/content-build/pull/1661 The QA steps were followed in that PR and merged. Currently on prod
Appears resolved on prod per https://www.va.gov/poplar-bluff-health-care/register-for-care/ and https://www.va.gov/pittsburgh-health-care/register-for-care/
as well as per https://www.va.gov/pittsburgh-health-care/medical-records-office/ and https://www.va.gov/poplar-bluff-health-care/medical-records-office/
Thank you, @eselkin !!!
Have notified original reporting editor @ VA Poplar Bluff that this issue is now resolved
Closing.
Describe the defect
As an editor working on VAMC System Medical Records Office and VAMC System Register for Care pages for my section, I need to add linked VAMC Facility Non-clinical Service nodes reflecting the address, hours, and contact info for Medical Records and Register for Care offices at individual facilities.
When adding facility-specific Medical Records and Register for Care office information, there is a checkbox with the option
Use the general facility phone number.
Users also have the option to add additional phone numbers, if needed.However, the “Main phone” field for each facility isn’t showing up on the published Medical Records and Register for Care pages regardless of whether or not this box has been checked, or whether any additional phone numbers have been added.
To Reproduce
Steps to reproduce the behavior:
Use the general facility phone number
checkboxAC / Expected behavior
When the
Use the general facility phone number
checkbox is checked on a VAMC Facility Non-clinical Service featured within a VAMC System Medical Records Office or VAMC System Register for Care node, then the "Main Phone" field should display the main phone number for that facility instead of being blank.Screenshots
Additional context
Should be prioritized since this affects patients seeking access to medical records and registering for care
See Slack thread from #facilities-support: https://dsva.slack.com/archives/C02730UEZPS/p1690835620274939
Desktop (please complete the following information if relevant, or delete)
Labels
(You can delete this section once it's complete)
Team
Please check the team(s) that will do this work.
CMS Team
Public Websites
Facilities
User support
Accelerated Publishing