department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

I.L. FE: Incorrect accordion header levels on "Your income limits" page #14593

Closed laflannery closed 1 year ago

laflannery commented 1 year ago

Description

On the last page of the Income Limits app, where the user sees all the accordions with various income level options, the accordion header levels are incorrect for the page hierarchy. They are currently H2s but they should be H3s.

image

User story

AS A Veteran using assistive technology I WANT the heading hierarchy of the page to be properly defined SO THAT I can easily understand the page structure and navigate directly to the section relevant to me.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

wesrowe commented 1 year ago

@randimays, here's a small a11y ticket for I.L. 2-pointer?

randimays commented 1 year ago

@wesrowe I thought the smallest dev story (requiring a PR) would be 3 points? Either way, it's pretty small. 2 or 3 works.

randimays commented 1 year ago

I have a PR open for this: https://github.com/department-of-veterans-affairs/vets-website/pull/25110 but the review instance isn't working yet. I'll have to take another look at this on Wednesday. If we need to get this across the line before I get back, please feel free to take action on it.

laflannery commented 1 year ago

The review instance is working now however I can't get through the app in order to get to the last page - the zip code screen isn't allowing me to get past, it's saying that valid zip codes are all invalid:

image

This is also happening on the PR that @chriskim2311 had me review for the auto-scrolling

Tagging @wesrowe because I wasn't sure if this was something he should/could take a look at as well?

laflannery commented 1 year ago

Chris explained to me that this was never going to work in the review instance. I looked at Randi's screenshot instead and this is approved from an accessibility standpoint

randimays commented 1 year ago

Verified this is working as expected in Staging. Closing.

Screenshot 2023-08-09 at 4 36 17 PM