Filter VAMC Mobile Vet Centers and VAMC Mobile Clinics from Events' 'location type' Reference Field

dsasser commented 1 year ago

Description

Mobile clinics and mobile center addresses, as stored in the field_address field on the Facility, do not correlate to their actual location during their respective events, but instead to the address where the mobile vehicle is garaged. Because we are handling event address display differently soon in the FE, we need to ensure that the mobile event addresses are not used, because that would route attendees to an invalid location.

User story

AS A veteran I WANT to see relevant event locations for mobile events SO THAT I can attend the event

Engineering notes / background

https://github.com/department-of-veterans-affairs/va.gov-cms/issues/13222#issuecomment-1688591576

Acceptance criteria

[ ] When editing/creating an event, the "Location type" option "At a VA facility" should not return mobile centers/facilities
[ ] Event cypress test updated to include a test for this

wesrowe commented 1 year ago

@dsasser, can you add points? I think you called it "trivial" in slack.

jilladams commented 1 year ago

@wesrowe and I discussed implementation here with @davidconlon again today, re: original decision on 5/22 (here). Dave expressed his appreciation that the team re-surfaced this, and is thankful we are thinking through the Veteran's experience. From his perspective:

We do not know at this point if any editors will ever create events for mobile locations.
While 2 points is cheap to filter, it's also 2 points for theoretical use cases. Adding this work, testing, shipping is smallish but still will slow down some progress toward other Events-related high priority work that will follow (single source of truth for the national calendar).

With those things in mind, Dave understands it's frustrating, but his preference remains that we leave mobile locations in the mix of Facilities that could be used for Events. This ticket becomes a ~~Icebox~~ backlog item that we can pull into a sprint if / when we get Veteran / Editor feedback that this experience is disruptive / problematic, and prioritize at that time.

EDIT: we circled back to this toward the end of the meeting, and Dave clarified that it is a backlog item, not icebox. He just wants to be very clear that it's more important to get events onto the (national) outreach calendar than to do this piece. He's open to us doing it sooner if it would not be slowing that or other higher-priority initiatives down. (For example, that outreach initiative is currently awaiting design.)

wesrowe commented 1 year ago

@jilladams, note my edit to your comment above

jilladams commented 1 year ago

Thanks, I had missed that note in the flow of the meeting.

aklausmeier commented 5 months ago

Palo Alto does currently use events for mobile clinics. While it doesn't meet their full needs, calling out the use case.

Event list

Event detail page

department-of-veterans-affairs / va.gov-cms