department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

PAW: Implement checkbox and radio button validation #14952

Closed wesrowe closed 1 year ago

wesrowe commented 1 year ago

Description

User story

AS A Veteran I WANT to be alerted clearly when I have not provided a required response to a question SO THAT I can continue with minimal cognitive difficulty.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

Consider

  • Design / Accessibility reviews
  • Collab cycle requirements
  • Device sizes (mobile first)
  • Documentation updates / Change management < - Content model documentation
  • Testing notes
randimays commented 1 year ago

PR up for review: https://github.com/department-of-veterans-affairs/vets-website/pull/25685

It piggybacks on the Burn Pit questions PR, so that one needs to get merged in first.

thejordanwood commented 1 year ago

@randimays This has design approval!

edit: This has design approval for radio buttons.

randimays commented 1 year ago

Holding the ticket until Agent Orange questions are ready so we can also validate the error messaging for checkboxes.

randimays commented 1 year ago

End of sprint update: this ticket is paired with the release of Agent Orange. We still need to validate the checkbox error message. It will carry over, but only for a day or so I imagine.

randimays commented 1 year ago

Jordan approved the validation for checkbox error messages. Slack thread. Closing!

randimays commented 1 year ago

Re-opening. I closed this too early; the code hasn't been merged yet. Will close again when it's validated in staging.

randimays commented 1 year ago

Validated in staging. Closing!