department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 68 forks source link

Redirect Request - CPAP Form base URL change - deployed to prod & verified by Fri 9/29 EOD #15352

Closed JasmineYohannan closed 1 year ago

JasmineYohannan commented 1 year ago

For Mon 10/2 availability, this redirect needs to be complete, merged, deployed and verified in Prod by EOD Fri 9/29

Implementation date

When does this request need to be live? Choose one:

Redirects

current URL new URL
https://www.va.gov/health-care/order-hearing-aid-batteries-and-accessories/order-form-2346/ and all child pages https://www.va.gov/health-care/order-hearing-aid-or-cpap-supplies-form/

Process, Roles and Responsibilities

mnorthuis commented 1 year ago

@JasmineYohannan FYI that changing this URL will impact the child pages as well, so that needs to be included here. There is a form for ordering hearing aid batteries that will also need to be updated.

kristinoletmuskat commented 1 year ago

@JasmineYohannan I'll make those updates here after we decide on the H1 with content!

jilladams commented 1 year ago

@kristinoletmuskat @mnorthuis this is ready for Public Websites to implement, or still waiting on review? cc @wesrowe

kristinoletmuskat commented 1 year ago

@jilladams still waiting on finalizing some changes to the H1 with the team (and thus the url)

JasmineYohannan commented 1 year ago

@kristinoletmuskat what is the update to the H1 that is being decided on?

Also @jilladams please note the child pages as well

jilladams commented 1 year ago

Thanks, unassigning myself for now and please reassign me when this is ready for our team to run with.

kristinoletmuskat commented 1 year ago

Hey @JasmineYohannan, just adding the parts of this convo that I sent in slack here too: Screenshot 2023-09-12 at 4 29 47 PM

kristinoletmuskat commented 1 year ago

@JasmineYohannan could you add the form URL to the redirect request above? I think the URL that was listed there was the static page url, not the form url.

I also just updated the url to exclude the form numbers, since there are two numbers and we decided the url would be too long / unreadable.

kristinoletmuskat commented 1 year ago

Hey @JasmineYohannan wanted to ping you again -- we just need the current URL for the hearing aids form. I couldn't get it in staging because it wouldn't load.

JasmineYohannan commented 1 year ago

Hi @kristinoletmuskat https://www.va.gov/health-care/order-hearing-aid-batteries-and-accessories/ is this the link you mean? Or is it the link of the logged in form

kristinoletmuskat commented 1 year ago

@JasmineYohannan no it's the link to the logged-in form!

kristinoletmuskat commented 1 year ago

@jilladams we're ready on this!

jilladams commented 1 year ago

Question re: timing, @JasmineYohannan - can you clarify what's driving that time window, so our team can keep it in mind? For reference, we'll put this in our next sprint that starts W 9/27, and will need to request an OOB deploy in order to get it out during 9/18/23 -10/2/23 window (since the next natural date it could release would be W 10/4).

@kristinoletmuskat @mnorthuis - Have added the note re: child pages into the "current URL" area of the ticket -- I think this should be best practices moving forward, to make sure that the ticket body reflects work our team will pick up in future, since it's easy to lose details like that in the comment threads. Thanks!

kristinoletmuskat commented 1 year ago

@jilladams that sounds great -- we can add that note in future redirect requests.

JasmineYohannan commented 1 year ago

@jilladams our DLC team wants to start telling Veterans about this functionality starting 10/2, so we wanted to have the redirect done for then.

JasmineYohannan commented 1 year ago

@jilladams @chriskim2311 as an update - before the redirect happens, we need to make sure the app is actually configured to be accessible via the new URL. that is not currently the case. we’re working on a plan to make this happen, but it will take a few days. cc: @batemapf

chriskim2311 commented 1 year ago

@kristinoletmuskat @JasmineYohannan @jilladams Thank you for the update, Will this delay the release of this redirect? Do we still need it for 10/2? I checked both URLs and they are both not working currently as Jasmine commented above.

jilladams commented 1 year ago

I had an email update here from @JasmineYohannan saying this would likely need to go out midweek instead, but that's not appearing on ticket anymore. @JasmineYohannan could you clarify timing?

JasmineYohannan commented 1 year ago

@jilladams @chriskim2311 Confirming that given where things are right now, we will need to push the redirect release to mid-late next week.

jilladams commented 1 year ago

@JasmineYohannan any updates here?

JasmineYohannan commented 1 year ago

@kristinoletmuskat is everything okay on the static page end to have this happen?

kristinoletmuskat commented 1 year ago

Yes we can make this change!

chriskim2311 commented 1 year ago

@kristinoletmuskat Are these authenticated user only pages?

kristinoletmuskat commented 1 year ago

Yes! You have to sign in to do the form. @chriskim2311

chriskim2311 commented 1 year ago

@JasmineYohannan @jilladams @kristenmcconnell This has been merged. Do we need to request an OOB deploy or can it go out with the normal deploy on Wednesday morning?

JasmineYohannan commented 1 year ago

@chriskim2311 Can we have the casing be CPAP? (or else revproxy needs to redirect it again from cpap to CPAP).

jilladams commented 1 year ago

@chriskim2311 I tested based on our discussion --- right now the lowercase cpap resolves to CPAP.

Input URL Resolves to
https://www.va.gov/health-care/order-hearing-aid-or-cpap-supplies-form (with or without / ) https://www.va.gov/health-care/order-hearing-aid-or-CPAP-supplies-form/introduction
https://www.va.gov/health-care/order-hearing-aid-or-CPAP-supplies-form (with or without / ) https://www.va.gov/health-care/order-hearing-aid-or-CPAP-supplies-form/introduction
https://www.va.gov/health-care/order-hearing-aid-or-CPAP-supplies-form/introduction https://www.va.gov/health-care/order-hearing-aid-or-CPAP-supplies-form/introduction
https://www.va.gov/health-care/order-hearing-aid-or-CPAP-supplies-form/introduction https://www.va.gov/health-care/order-hearing-aid-or-CPAP-supplies-form/introduction
jilladams commented 1 year ago

It looks like this came in via Patrick Bateman here, so is already handled: https://github.com/department-of-veterans-affairs/devops/pull/13533

JasmineYohannan commented 1 year ago

Hi @jilladams @chriskim2311 I apologize for the inconvenience this will cause but we need to pull this redirect back which will be reverting devops/pull/13503) so it doesnt go out with the daily revproxy deploy. or if it has already, then we’ll need to get it pulled out before we do anything else.

JasmineYohannan commented 1 year ago

The URL needs to be all lowercase per best practice/standards

jilladams commented 1 year ago

Apologies, just seeing this now. @JasmineYohannan are you available in DSVA slack? That might shorten our cycles. I'm gonna start a thread there to help us move fast to get this fixed tomorrow. https://dsva.slack.com/archives/C01K37HRUAH/p1697674982893309

jilladams commented 1 year ago

https://dsva.slack.com/archives/C01K37HRUAH/p1697736620742869?thread_ts=1697674982.893309&cid=C01K37HRUAH From Patrick Bateman

hi, sorry folks, been in and out today. tl;dr, everything is fine in its current state and i need to map how i think we should proceed with getting everything to no caps. the problem lies in the fact that both vets-website and revproxy changes are needed (and actually content build too) and since we can’t guarantee deploys of those changes will be perfectly timed, i think we need a temporary state to cover us. will come up with strategy next week and run it by here.

Laura Willwerth confirmed with Patrick that all caps CPAP can stay in prod until any changes.

This in mind, closing this ticket as complete, and we can create follow up tickets for any additional changes from the current state of things in prod.