department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

VAMC services are showing too much of the service term on node view. #15387

Open swirtSJW opened 1 year ago

swirtSJW commented 1 year ago

Describe the defect

When I visit a VAMC Facility Health Service I see too much data related to the selected service

image

The same is true for system services. image

To Reproduce

Steps to reproduce the behavior:

  1. Go to '/columbia-south-carolina-health-care/locations/anderson-va-clinic/addiction-and-substance-use-care'
  2. See under the "Service name and description" there are bunch of other fields from the service term that should not be showing.

AC / Expected behavior

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here. Reach out to the Product Managers to determine if it should be escalated as critical (prevents users from accomplishing their work with no known workaround and needs to be addressed within 2 business days).

Desktop (please complete the following information if relevant, or delete)

Labels

(You can delete this section once it's complete)

Team

Please check the team(s) that will do this work.

davidmpickett commented 1 year ago

I fell down some pretty deep rabbit holes trying to understand this today. Some things I learned which may or may not help narrow down the issue:

1) The VAMC Facility Health service node.view display is referencing the VAMC System Health Service as a Rendered Entity with the Teaser View Mode. So the root problem can't be on VAMC Facility Health Service, it's inheriting this issue from VAMC System Health Service.

screencapture-staging-cms-va-gov-admin-structure-types-manage-health-care-local-health-service-display-2023-10-09-18_11_21

2) The VAMC Facility Health Service in turn is referencing the "Service Name" (field_service_name_and_descripti) and displaying that as a rendered entity with the Default View Mode. I thought it might be as simple as updating that View Mode to fix this, but my attempts to do that didn't seem to bear any fruit.

screencapture-staging-cms-va-gov-admin-structure-types-manage-regional-health-care-service-des-display-2023-10-09-18_14_12

3) I traced the source back even further to the vha_health_service_taxonomy View, and spent some time fiddling with Displays within the View etc to try and figure something out, but was out of my depth at that point. Views are complicated

davidmpickett commented 1 year ago

Still not sure if I'm getting anywhere near the root of the issue, but I did learn why this isn't an issue on Vet Center Facility Services, because they don't use the Rendered Entity approach, they just are pulling in the service title

screencapture-cms-4mxyrwpvzanus5m7flwiottpojmvw7pn-ci-cms-va-gov-admin-structure-types-manage-vet-center-facility-health-servi-display-2023-10-09-21_01_32

davidmpickett commented 1 year ago

Proposed solution:

  1. Create a new Taxonomy Term View Mode (admin/structure/display-modes/view/add/taxonomy_term).
  2. Update the Display of VA Services and under Custom Display Settings enable the View Mode you just made (admin/structure/taxonomy/manage/health_care_service_taxonomy/overview/display)
  3. Switch to the new tab that just appeared and move all the unwanted fields to disabled
  4. Update the VAMC System Service Default and Teaser displays to have Service Name be Rendered this new View Mode instead of Default

1

screencapture-cms-4mxyrwpvzanus5m7flwiottpojmvw7pn-ci-cms-va-gov-admin-structure-display-modes-view-manage-taxonomy-term-vamc-facility-health-service-teaser-2023-10-09-22_22_18

2

Screenshot 2023-10-09 223245

3

screencapture-cms-4mxyrwpvzanus5m7flwiottpojmvw7pn-ci-cms-va-gov-admin-structure-taxonomy-manage-health-care-service-taxonomy-overview-display-vamc-facility-health-service-teaser-2023-10-09-22_21_44

4

screencapture-cms-4mxyrwpvzanus5m7flwiottpojmvw7pn-ci-cms-va-gov-admin-structure-types-manage-regional-health-care-service-des-display-2023-10-09-22_26_27

davidmpickett commented 1 year ago

Example of end result screencapture-cms-4mxyrwpvzanus5m7flwiottpojmvw7pn-ci-cms-va-gov-columbia-south-carolina-health-care-locations-anderson-va-clinic-addiction-and-substance-use-care-2023-10-09-22_46_47

davidmpickett commented 1 year ago

Proof of concept on tugboat attached to this PR: https://github.com/department-of-veterans-affairs/va.gov-cms/pull/15609

xiongjaneg commented 9 months ago

Question: Does this only apply to VAMCs?

Christian is not seeing it on Vet Centers.

Agile6MSkinner commented 4 months ago

From what I can see here, we're not even close to being able to point this. Moving it to the backlog.