department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 68 forks source link

VAMC: Empty "Expand all" label #15395

Open mmiddaugh opened 1 year ago

mmiddaugh commented 1 year ago

Description

Empty "Expand all" label displays without any available accordions to open

Steps to reproduce

  1. Visit the McAllen VA Mobile Clinic page
  2. Scroll down to the "Health services offered here" heading.
  3. Observe the "Expand all" label displayed immediately above the "Get updates from VA Texas Valley health care" box

Private Zenhub Image

Expected behavior

The option to open accordions is not present without accordions available to open.

(I'm not sure that empty "Health services offered here" heading should display either - although I know there is an expectation that at least one health service will be added.

laflannery commented 1 year ago

From an accessibility standpoint, I do not want the heading or the content ("Click on a service for more details like location, contact, and appointment information.") here in cases where there are no services present. It is misleading and could lead to confusion.

I know @mmiddaugh mentioned in the description that there is an expectation that at leas one service would be added so is this something we can force on the Drupal side?