department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Header megamenu: Menu links not explicitly connecting to their Promo #15491

Open jilladams opened 1 year ago

jilladams commented 1 year ago

Status

[2024-07-02] Slack message to Micah/Carol about transferring this ticket to their team repo for their Header/footer epic. [2024-02-16] Comment in ticket to Micah in DST: Here's a ticket for your team's consideration when they componentize the header/footer.

To Do Refinement session 1/9:

Description

https://dsva.slack.com/archives/CDHBKAL9W/p1696271256885979

In the megamenu, the benefit areas can be expanded, and include a Promo block, e.g.:

Screenshot 2023-10-02 at 11 40 18 AM

The Promo block used in the menu should ideally be connected to the menu item via Drupal. But in some cases, a menu item that is displaying a Promo block in the FE does not have that Promo block relationship set in the menu item > Related Promo field. (How is the FE getting the right block to display, without this field value? Great question: content-build is reverse engineering and grabbing related promo from the Benefit page itself, when needed. More notes: https://dsva.slack.com/archives/CDHBKAL9W/p1696272554275839?thread_ts=1696271256.885979&cid=CDHBKAL9W)

Menu: https://prod.cms.va.gov/admin/structure/menu/manage/header-megamenu Terms that display a Promo block in the FE, but do not have the value set in the Menu Item:

User story

AS A Drupal maintainer I WANT to ensure that data connections are established correctly in Drupal SO THAT we don't accidentally regress the megamenu

Engineering / testing notes

It is probably simple to just select the right promo and set it in the Menu Items. But because the header works today without those field values, we want to test this locally first to make sure nothing breaks when we add the values to Drupal.

Acceptance criteria

jilladams commented 1 year ago

It's a FE task to make sure content-build doesn't get weird once these block values are added, but might need CMS people help to get that data local for testing? Not clear to me.

FranECross commented 11 months ago

@FranECross Split into two tickets for FE and BE. FE estimate swag 2-3

FranECross commented 8 months ago

@micahchiang Here's a ticket for your team's consideration when they componentize the header/footer.