search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
97 stars 69 forks source link

Some users have been assigned Roles that do not exist #15551

Open swirtSJW opened 1 year ago

swirtSJW commented 1 year ago

Describe the defect

In working on a new user-related report (/admin/reports/system/user-roles, deploying to production today 10/5), I discovered some users have some Roles assigned that are not standard Roles, including:

My hunch is that this came during times when we have bulk imported users. I think the source was mangled so we got a bad imports which pumped these directly into the user's role without validating if the role matched an actual role.

Summary: We have ~220 bad roles assigned to users.

Role includes typos, or includes spaces / additional quotes

"vamc_content_createor" : 1 " content_creator_vet_center" : 1 ""content_creator_vet_center" : 9
"content_editor"" : 9

Listed Role is not an existing system Role

"content_creator_outreach_hub" : 1 the machine name that matches this name is office_content_creator "content-creator-vet-center" : 80 Roles use underscores not hyphens "content-editor" : 80 Roles use underscores not hyphens

Listed Role is a section term, not a Role

"VA Black Hills health care" : 1
"VA Cheyenne health care" : 1 "VA Durham health care" : 2 "VA Eastern Colorado health care" : 2 "VA Eastern Oklahoma health care" : 2 "VA Gulf Coast health care" : 2 "VA Iowa City health care" : 1 "VAMC Facilities" : 1 "VA Minneapolis health care" : 1 "VA Nebraska-Western Iowa health care" : 1 "VA Northern California health care" : 1 "VA Oklahoma City health care" : 1 "VA Pacific Islands health care" : 1 "VA Palo Alto health care" : 1 "VA Richmond health care" : 1 "VA Salem health care" : 2 "VA Salt Lake City health care" : 1 "VA San Francisco health care" : 1 "VA Shreveport health care" : 1 "VA Sierra Nevada health care" : 1 "VA Sioux Falls health care" : 1 "VA Southeast Louisiana health care" : 2 "VA Southern Nevada health care" : 2 "VA St Cloud health care" : 1 "VISN 6" : 1 "VISN 16" : 1 "VISN 21" : 2 "VISN 23" : 1

Correct Roles

"administrator" : 61 "admnistrator_users" : 4 (yes this has a typo in it, but it is a legit role) "content_admin" : 20 "content_api_consumer" : 13 "content_creator_benefits_hubs" : 3 "content_creator_resources_and_support" : 19 "content_creator_vet_center" : 646 "content_editor" : 203 "content_publisher" : 1261 "content_reviewer" : 28 "homepage_manager" : 4 "office_content_creator" : 108 "redirect_administrator" : 8 "translation_manager" : 2 "vamc_content_creator" : 646

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to /admin/reports/system/user-roles. (will exist in prod by EOD 10/5)
  2. Scroll down below the second chart and expand the "Errors found" section image

AC / Expected behavior

swirtSJW commented 1 year ago

Here is the list of user accounts and their flaws.

 Derek.Graner@va.gov: 'content-creator-vet-center'
Derek.Graner@va.gov: 'content-editor'
Ronald.Wrigley@va.gov: 'content-creator-vet-center'
Ronald.Wrigley@va.gov: 'content-editor'
Terri.Davis2@va.gov: 'content-creator-vet-center'
Terri.Davis2@va.gov: 'content-editor'
Theresa.Blevins@va.gov: 'content-creator-vet-center'
Theresa.Blevins@va.gov: 'content-editor'
Winona.Franklin@va.gov: 'content-creator-vet-center'
Winona.Franklin@va.gov: 'content-editor'
Melanie.Keller@va.gov: 'content-creator-vet-center'
Melanie.Keller@va.gov: 'content-editor'
Richard.Martin12@va.gov: 'content-creator-vet-center'
Richard.Martin12@va.gov: 'content-editor'
James.Capobianco@va.gov: 'content-creator-vet-center'
James.Capobianco@va.gov: 'content-editor'
Etzer.Lalanne@va.gov: 'content-creator-vet-center'
Etzer.Lalanne@va.gov: 'content-editor'
Vernon.Stewart@va.gov: 'VA Gulf Coast health care'
Edward.Tague@va.gov: 'content-creator-vet-center'
Edward.Tague@va.gov: 'content-editor'
Andrea.Ritz@va.gov: 'VA Palo Alto health care'
Mary.Fisher@va.gov: 'content-creator-vet-center'
Mary.Fisher@va.gov: 'content-editor'
Ingrid.Rincon@va.gov: 'content-creator-vet-center'
Ingrid.Rincon@va.gov: 'content-editor'
James.Barnhill@va.gov: '"content_creator_vet_center'
James.Barnhill@va.gov: 'content_editor"'
Joseph.Dudley@va.gov: 'content-creator-vet-center'
Joseph.Dudley@va.gov: 'content-editor'
Tameka.Adams-Allen@va.gov: 'content-creator-vet-center'
Tameka.Adams-Allen@va.gov: 'content-editor'
David.Soldano@va.gov: 'content-creator-vet-center'
David.Soldano@va.gov: 'content-editor'
Pamela.winkelman@va.gov: 'VA St Cloud health care'
Matthew.Standish@va.gov: 'content-creator-vet-center'
Matthew.Standish@va.gov: 'content-editor'
Bruce.Cummins@va.gov: 'VA Gulf Coast health care'
Holley.Brock@va.gov: 'content-creator-vet-center'
Holley.Brock@va.gov: 'content-editor'
Juan.Roldan@va.gov: 'content-creator-vet-center'
Juan.Roldan@va.gov: 'content-editor'
Lyle.Allen@va.gov: 'content-creator-vet-center'
Lyle.Allen@va.gov: 'content-editor'
Jemar.Ridley@va.gov: 'content-creator-vet-center'
Jemar.Ridley@va.gov: 'content-editor'
John.Shafer1@va.gov: 'content-creator-vet-center'
John.Shafer1@va.gov: 'content-editor'
Jerlunda.Wilson@va.gov: 'content-creator-vet-center'
Jerlunda.Wilson@va.gov: 'content-editor'
Kate.Hoit@va.gov: 'content_creator_outreach_hub'
Shahron.James@va.gov: 'VA Durham health care'
Marty.Job@va.gov: 'content-creator-vet-center'
Marty.Job@va.gov: 'content-editor'
Kelven.Eden@va.gov: 'content-creator-vet-center'
Kelven.Eden@va.gov: 'content-editor'
Charles.Ramey2@va.gov: 'VA Southern Nevada health care'
Ronald.Fazio@va.gov: 'content-creator-vet-center'
Ronald.Fazio@va.gov: 'content-editor'
Jaime.Barzana@va.gov: 'content-creator-vet-center'
Jaime.Barzana@va.gov: 'content-editor'
ryan.coverdell@va.gov: 'VA Sierra Nevada health care'
Jannira.Roman@va.gov: 'content-creator-vet-center'
Jannira.Roman@va.gov: 'content-editor'
Troy.stormoen@va.gov: '"content_creator_vet_center'
Troy.stormoen@va.gov: 'content_editor"'
Dorothy.Whitely@va.gov: 'content-creator-vet-center'
Dorothy.Whitely@va.gov: 'content-editor'
James.Adkins@va.gov: 'content-creator-vet-center'
James.Adkins@va.gov: 'content-editor'
Matthew.Haddon@va.gov: 'VA Eastern Colorado health care'
Gertrudis.Perez-Dusek@va.gov: 'content-creator-vet-center'
Gertrudis.Perez-Dusek@va.gov: 'content-editor'
Sandra.Medina-Torres@va.gov: 'content-creator-vet-center'
Sandra.Medina-Torres@va.gov: 'content-editor'
James.Dickey1@va.gov: 'content-creator-vet-center'
James.Dickey1@va.gov: 'content-editor'
Maureen.Dyman@va.gov: 'VISN 16'
Witt.Cook@va.gov: '"content_creator_vet_center'
Witt.Cook@va.gov: 'content_editor"'
Gloria.Rohlfs@va.gov: 'VA Pacific Islands health care'
Byron.Rowe@va.gov: 'content-creator-vet-center'
Byron.Rowe@va.gov: 'content-editor'
Robert.Cash@va.gov: 'content-creator-vet-center'
Robert.Cash@va.gov: 'content-editor'
Douglas.McQueen3@va.gov: 'content-creator-vet-center'
Douglas.McQueen3@va.gov: 'content-editor'
Kevin.Hynes@va.gov: 'VA Nebraska-Western Iowa health care'
Byron.Giles@va.gov: 'VA Shreveport health care'
BaDonna.Mitchell@va.gov: 'content-creator-vet-center'
BaDonna.Mitchell@va.gov: 'content-editor'
david.martinez@va.gov: 'VA Southern Nevada health care'
Shavondria.Davis@va.gov: 'content-creator-vet-center'
Shavondria.Davis@va.gov: 'content-editor'
Emily.Feeback@va.gov: 'content-creator-vet-center'
Emily.Feeback@va.gov: 'content-editor'
Anna.Guerrero@va.gov: 'content-creator-vet-center'
Anna.Guerrero@va.gov: 'content-editor'
Kevin.Baker10@va.gov: 'content-creator-vet-center'
Kevin.Baker10@va.gov: 'content-editor'
Emily.Shannon2@va.gov: 'content-creator-vet-center'
Emily.Shannon2@va.gov: 'content-editor'
Sonya.Campbell1@va.gov: 'content-creator-vet-center'
Sonya.Campbell1@va.gov: 'content-editor'
Erika.Reynolds@va.gov: '"content_creator_vet_center'
Erika.Reynolds@va.gov: 'content_editor"'
Kelly.Mcallister@va.gov: '"content_creator_vet_center'
Kelly.Mcallister@va.gov: 'content_editor"'
Teresa.Forbes@va.gov: 'VA Black Hills health care'
Patricia.Wasisco@va.gov: 'content-creator-vet-center'
Patricia.Wasisco@va.gov: 'content-editor'
Timothy.parish@va.gov: 'VA Richmond health care'
Scott.Hartford@va.gov: 'content-creator-vet-center'
Scott.Hartford@va.gov: 'content-editor'
Tifany.Hill@va.gov: 'content-creator-vet-center'
Tifany.Hill@va.gov: 'content-editor'
Michael.Tucker4@va.gov: 'content-creator-vet-center'
Michael.Tucker4@va.gov: 'content-editor'
Melissa.Saunders@va.gov: 'content-creator-vet-center'
Melissa.Saunders@va.gov: 'content-editor'
Sandra.Roy@va.gov: 'VA Minneapolis health care'
Deborah.Ross4@va.gov: 'content-creator-vet-center'
Deborah.Ross4@va.gov: 'content-editor'
Erin.Bultje@va.gov: 'VA Sioux Falls health care'
Tiffani.Mathews@va.gov: 'VA Eastern Oklahoma health care'
Kingston.Dillard@va.gov: 'VISN 21'
Ron.Woolery@va.gov: 'VISN 23'
Carmalita.Gaines@va.gov: 'content-creator-vet-center'
Carmalita.Gaines@va.gov: 'content-editor'
Michael.Evans1@va.gov: 'content-creator-vet-center'
Michael.Evans1@va.gov: 'content-editor'
Raul.Diaz2@va.gov: 'content-creator-vet-center'
Raul.Diaz2@va.gov: 'content-editor'
Christopher.Jensen2@va.gov: '"content_creator_vet_center'
Christopher.Jensen2@va.gov: 'content_editor"'
Adele.Leinbach@va.gov: 'content-creator-vet-center'
Adele.Leinbach@va.gov: 'content-editor'
brandy.morrison2@va.gov: 'VA Eastern Colorado health care'
Sherri.Eng@va.gov: 'VA San Francisco health care'
Kristel.Jimenez-Santiago@va.gov: 'content-creator-vet-center'
Kristel.Jimenez-Santiago@va.gov: 'content-editor'
Jeff.Flowers@va.gov: 'content-creator-vet-center'
Jeff.Flowers@va.gov: 'content-editor'
laura.wilson5@va.gov: 'VA Northern California health care'
Timothy.Prendergast@va.gov: 'content-creator-vet-center'
Timothy.Prendergast@va.gov: 'content-editor'
angela.gilmore1@va.gov: 'vamc_content_createor'
DonLarae.Richardson2@va.gov: 'content-creator-vet-center'
DonLarae.Richardson2@va.gov: 'content-editor'
Kristen.Marchak@va.gov: 'content-creator-vet-center'
Kristen.Marchak@va.gov: 'content-editor'
Penny.Genous@va.gov: 'content-creator-vet-center'
Penny.Genous@va.gov: 'content-editor'
Daniel.Rodriguez7@va.gov: 'content-creator-vet-center'
Daniel.Rodriguez7@va.gov: 'content-editor'
Rosaire.Bushey@va.gov: 'VA Salem health care'
Bryan.Clark@va.gov: 'VA Iowa City health care'
samuel.house2@va.gov: 'VA Cheyenne health care'
Brittany.Gray1@va.gov: 'content-creator-vet-center'
Brittany.Gray1@va.gov: 'content-editor'
Denesse.Torpoco@va.gov: 'content-creator-vet-center'
Denesse.Torpoco@va.gov: 'content-editor'
Wilfredo.Florez@va.gov: 'content-creator-vet-center'
Wilfredo.Florez@va.gov: 'content-editor'
joshua.avist@va.gov: 'VA Southeast Louisiana health care'
Richard.Ferry@va.gov: '"content_creator_vet_center'
Richard.Ferry@va.gov: 'content_editor"'
Phillip.Walls@va.gov: 'VA Southeast Louisiana health care'
Austin.wilmarth@va.gov: '"content_creator_vet_center'
Austin.wilmarth@va.gov: 'content_editor"'
Anthony.Ziarnowski@va.gov: '    content_creator_vet_center'
Matthew.Eaton@va.gov: 'content-creator-vet-center'
Matthew.Eaton@va.gov: 'content-editor'
Latoia.Linebarger@va.gov: 'content-creator-vet-center'
Latoia.Linebarger@va.gov: 'content-editor'
Mark.Martin@va.gov: 'content-creator-vet-center'
Mark.Martin@va.gov: 'content-editor'
Daniel.Boye@va.gov: 'content-creator-vet-center'
Daniel.Boye@va.gov: 'content-editor'
Joshua.Edson@va.gov: 'VA Durham health care'
Deborah.Sawyer@va.gov: 'content-creator-vet-center'
Deborah.Sawyer@va.gov: 'content-editor'
Benita.McClellan@va.gov: 'VA Eastern Oklahoma health care'
ron.tafoy@va.gov: 'VAMC Facilities'
Anthony.Gardiner@va.gov: 'content-creator-vet-center'
Anthony.Gardiner@va.gov: 'content-editor'
Armenthis.Lester@va.gov: 'VISN 21'
Cynthia.Dodge3@va.gov: '"content_creator_vet_center'
Cynthia.Dodge3@va.gov: 'content_editor"'
Stephen.Wilkins2@va.gov: 'VISN 6'
shelby.benois@va.gov: 'VA Salem health care'
Wilfrido.Torres-Rivas@va.gov: 'content-creator-vet-center'
Wilfrido.Torres-Rivas@va.gov: 'content-editor'
Adam.Lobrutto@va.gov: 'content-creator-vet-center'
Adam.Lobrutto@va.gov: 'content-editor'
Frederick.Smith6@va.gov: 'content-creator-vet-center'
Frederick.Smith6@va.gov: 'content-editor'
William.Snyder1@va.gov: 'content-creator-vet-center'
William.Snyder1@va.gov: 'content-editor'
Gina.Maniaci2@va.gov: 'content-creator-vet-center'
Gina.Maniaci2@va.gov: 'content-editor'
jill.atwood@va.gov: 'VA Salt Lake City health care'
Timothy.Staebell2@va.gov: 'content-creator-vet-center'
Timothy.Staebell2@va.gov: 'content-editor'
Monica.Holland@va.gov: 'content-creator-vet-center'
Monica.Holland@va.gov: 'content-editor'
Holli.Kelly@va.gov: 'content-creator-vet-center'
Holli.Kelly@va.gov: 'content-editor'
Christopher.Aranda@va.gov: 'content-creator-vet-center'
Christopher.Aranda@va.gov: 'content-editor'
Curtishia.Starling@va.gov: 'content-creator-vet-center'
Curtishia.Starling@va.gov: 'content-editor'
phillip.ybarra@va.gov: 'VA Oklahoma City health care'
Jerry.Long3@va.gov: 'content-creator-vet-center'
Jerry.Long3@va.gov: 'content-editor'
Tia.Seals@va.gov: 'content-creator-vet-center'
Tia.Seals@va.gov: 'content-editor'
swirtSJW commented 1 year ago

Editing a specific user's roles and saving does not remove the the user's incorrect roles. They still persist.

jilladams commented 1 year ago

Thanks Steve. Reviewed, made some edits for clarity, passing along to CMS team.

BerniXiongA6 commented 1 year ago

Hey @ndouglas when you're able to with your next async pre-refinement activities, could I have you triage this request for our team? Thanks!

ndouglas commented 1 year ago

@BerniXiongA6 Sure. I think it falls in our area, I think it's worth fixing, and I don't think it will be too painful to actually do. I don't know if it actually really poses a problem right now, but it could potentially be the source of some weird issues/corner cases now or down the line.

Good catch, @swirtSJW!

swirtSJW commented 1 year ago

On prod, the number of errors seem smaller (170) because it is only logging errors to active accounts. On staging, where the error count is 217, it is logging all users because they are all set to active on lower environments. Fixing all regardless of active status would prevent any from returning.