Resolve content model tentacles on 10089 Events checkbox

[jilladams]

Description

10089 added an Events checkbox to the Events form.

This change shipped and broke the content model in the front end in 2 known places:

1. Outreach Materials -- not displaying Publications in VA.gov frontend
2. VAMC Stories (example) -- "See all stories" link is missing at the foot of the page.
3. We also need to re-verify Lovell, per Tim, though still no smoking gun for what that might mean

Slack threads

Topline for DaveC

Engineering notes

Feature Toggle may still be "ON" in prod, despite the revert of our code which created it.

We need to be careful about the `FEATURE_EVENT_OUTREACH_CHECKBOX` feature toggle being deployed as "enabled". The latest CMS mirror is showing it as enabled, but unsure if this was because the snapshot was taken before the revert was deployed.

Everywhere field_listing is used in templates/queries

``` 10 results - 6 files src/site/layouts/news_story.drupal.liquid: 45

[jilladams]

Estimate doesn't factor Lovell complexity. Daniel to talk to AP folks and update as needed with Lovell in mind.

[dsasser]

Mid-sprint Update 10/19/23

When taking on this ticket, we were planning no architectural changes on the backend, and instead making the frontend (content-build) robust enough to handle both a single value and an array of values. However, this approach had a lot of technical debt built in, and little risk mitigation was possible.

Because of this, we are pivoting to a different architecture:

Backend Changes

• We will create a new field on the Event content type on the BE.
• This field will hold 'additional listings' (it is an entity reference field, just like field_listing)
• It will be hidden from view, and only populated with the correct Outreach calendar Event Listing reference if the checkbox is set.

Frontend (content-build) Changes

• An additional Graphql reverse entity query will be added to the existing nodeEventListing query, in the same way that the field_listing data is done.
• We will combine the event data from the two queries prior to piping into the event listing template. This will allow us to inject the data in a single location, without affecting vets-website's related React widget (we won't need to worry about combining, sorting, or other tasks beyond what we are doing in content-build).

Overall this approach is much safer, since we aren't touching the structure of an existing field, but adding another field which is brand new to the ecosystem.

[jilladams]

@dsasser I like this and also: it smells like we may get questions at code review time. Would it be worth bouncing this off any other Drupal folks for smell testing before we fully commit? Or feels very safe / uncontroversial as a fix?

[dsasser]

@dsasser I like this and also: it smells like we may get questions at code review time. Would it be worth bouncing this off any other Drupal folks for smell testing before we fully commit? Or feels very safe / uncontroversial as a fix?

Getting feedback during review time is adequate in this case.

[jilladams]

Testing notes: Thread related to testing: https://dsva.slack.com/archives/C52CL1PKQ/p1697837268281799?thread_ts=1697835404.910689&cid=C52CL1PKQ

Tugboat with feature toggle enabled: https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/admin/config/system/feature_toggle FE: https://web-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/

Editor login, roles, section	Event type	Expected behavior	Pass/fail in CMS	Pass/fail in FE
Timothy.Chavis@va.gov, Content creator - VAMC / Content publisher	event VAMC event AK, not Natl, recurring	Shoudn't see national checkbox	🟢 checkbox does not appear	🟢 Event published normally; AK Events listing fine
edward.mcevoy@va.gov; Content creator - outreach hub, Content publisher	event Outreach event, recurring	Shouldn't see the checkbox	🟢 checkbox does not appear	🟢 Event publishes correctly, appears on pg 7 of Outreach events, in correct sequence
Winfield.DanielsonIII@va.gov - shortlisted beta editor, Content creator - VAMC Bedford & Boston / Content publisher	event VAMC event, Boston, not recurring. National.	Should see / select National checkbox. Event should publish to Natl calendar	🟢 checkbox appears, is selected /s aved.	🟢 Event single page; Boston listing; Outreach calendar page 5 of results
Winfield.DanielsonIII@va.gov - shortlisted beta editor, Content creator - VAMC Bedford & Boston / Content publisher	event VAMC event, Bedford, not recurring. National.	Should see / select National checkbox. Event should publish to Natl calendar	🟢 checkbox appears, is selected /s aved.	- 🟢 single page - 🟢 Bedford listing - first occurrence appears. - 🟢 Outreach events listing first occurrence appears pg 7, 11/6; no further occurrences appear (11/13, pg 11).

Other FE tests:

Listings:

• 🟢 Stories - see all link is present / works (e.g. https://www.va.gov/minneapolis-health-care/stories/leading-the-way-in-stroke-care-for-veterans-at-the-minneapolis-va-health-care-system/)
• 🟢 Outreach materials - lists publications ,
• 🟢 Outreach events cal - displays events correctly in order, when national checkbox ones interleaved
• 🟢 Outreach events cal - Filters work for
  • Date range
  • Specific date
  • past

Recurring events: expected behavior

In production today, for a recurring event, only the next upcoming instance will appear in the Upcoming filter. https://www.va.gov/minneapolis-health-care/events/48206/ https://www.va.gov/minneapolis-health-care/events/?selectedOption=upcoming

• 10/23 recurrence appears
• 10/30 recurrence does not

https://www.va.gov/outreach-and-events/events/61561/ https://www.va.gov/outreach-and-events/events/

• 10/31 recurrence appears
• 11/7 recurrence does not

[dsasser]

Deployment Plan

• [x] Test changes in both this PR, and the related content-build together in a tugboat environment. Completed by Jill October 20, 2023 on this tugboat.
• A11y confirmation/testing by @laflannery in tugboat
• PRs (BE, FE) approved by PW and AP teams
• Merge the BE PR.
• Wait for deployment of the BE PR and test success.
• Merge the FE PR.

Jill meddled here

I moved this list as checkboxes into the body of the ticket, so it's easy to see next to ACs for modern state of truth.

[dsasser]

@laflannery when you get a chance, could you review this PR for a11y + breadcrumb signoff? Tugboat is hit or miss today, but you should be able to get in eventually if you keep trying. There is a list of existing FE pages that Jill created while testing that might be of interest to you.

[laflannery]

@dsasser I got in for a bit but wasn't able to test everything yet. However I do have one general QA item I wanted to mention - I saw this issue that I had flagged as a D10 issue and thought had been resolved in a previous ticket. Is it a problem that it's here in this tugboat?

[jilladams]

@dsasser @laflanner I see what Laura is seeing here: https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/node/62493/edit

I tried to repro that, using this new event: https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/node/62522/edit

• Created a new recurring event - don't see the 2nd set of date fields, in the Add form
• Saved as draft - don't see 2nd set of fields when editing after draft save
• Published - still don't see 2nd set of fields
• Modified recurrence from days to weeks = this change weirdly allowed me to save, but when I review, it removed my date data from the original event date settings (GAH, new bug, need to file it). https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/node/62522/revisions/view/817739/817740/visual_inline

Then got a 502. 😂 but will check when it's back up, re: whether the 2nd date fields appear.

[dsasser]

@dsasser @laflanner I see what Laura is seeing here: https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/node/62493/edit

I tried to repro that, using this new event: https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/node/62522/edit

• Created a new recurring event - don't see the 2nd set of date fields, in the Add form
• Saved as draft - don't see 2nd set of fields when editing after draft save
• Published - still don't see 2nd set of fields
• Modified recurrence from days to weeks = this change weirdly allowed me to save, but when I review, it removed my date data from the original event date settings (GAH, new bug, need to file it). https://cms-ytipldihujdcko41uemzx3w18e31hyof.ci.cms.va.gov/node/62522/revisions/view/817739/817740/visual_inline

Then got a 502. 😂 but will check when it's back up, re: whether the 2nd date fields appear.

I'm still not clear how to reproduce what you and @laflannery are seeing w/ the 2nd set of date fields. Noting that this would be an unexpected change, since we didn't change those fields in any way intentionally.

[laflannery]

@dsasser and @jilladams some notes:

• I think that extra fieldset is only showing on recurring events
  • I can see it on the 3 recurring events you have in the table above but NOT in the one non-recurring event and not in the new non-recurring event you made
• In the previous ticket, the D10 one, the issue was the combination of the version of the events module and D10 that caused that extra fieldset to show. Daniel and Edmund worked on it together to resolved that.
  • This Tugboat is not on D10 but I'm wondering if this is a new version of the module that is not working with our current version of Drupal?

[jilladams]

The D10 note is interesting - I know the CMS team was most recently planning to ship that 1st week of November. So I just realized: wow, we need to take that into account with this launch. I'll ping CMS channelt o confirm timing.

[dsasser]

@laflannery what is the behavior on staging/prod?

[laflannery]

Staging has this same behavior and shows me the extra fieldset:

So that being said I feel like I (or someone?) should just ignore this entirely here and ticket this separately right?

[jilladams]

Yes, good call. If in Staging, officially not tied to this feature and we can/should handle separately.

[laflannery]

So back to what I was actually supposed to be reviewing, using the table from Jill above:

Scenario 1

• FE breadcrumbs look good (it has the VAMC breadcrumbs as expected)
• FE accessibility approved

Scenario 2

• FE breadcrumbs look good (it has the Outreach breadcrumbs as expected)
• FE accessibility approved

Scenario 3

• FE breadcrumbs look good (it has the VAMC breadcrumbs coming from both listings as expected)
• FE accessibility approved

Scenario 4

• FE breadcrumbs look good (it has the VAMC breadcrumbs coming from both listings as expected)
• FE accessibility approved

CMS

• Tested logged in as me, Winfield and Timothy, no issues in any of those experiences. Approved

[jilladams]

( Noting: all test data at tugboat links i comments above got blown away by Tugboat refresh. )

[laflannery]

Everything is approved by me, breadcrumbs look good and not a11y issues!