department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Centralized Content: Blank heading on Edit node #15661

Open laflannery opened 1 year ago

laflannery commented 1 year ago

Describe the defect

As a content admin (NOT a super admin) on the edit node of centralized content, there is an empty H4

To Reproduce

Steps to reproduce the behavior:

  1. Log into the CMS as a Content admin (I was using Randi Hecht on staging)
  2. Edit an existing Centralized content node. Example: https://staging.cms.va.gov/node/61744/edit
  3. Scroll down to the "Content" section
  4. Inspect the heading and notice that there is a blank H4 above the H2

AC / Expected behavior

Screenshots

image

Team

Please check the team(s) that will do this work.

swirtSJW commented 1 year ago

Good catch @laflannery I believe this is coming out of the draggable table interface from Drupal core. It would be good to compare if Detail pages also have this problem as they use the same interface on field_content_block. It would help rule out if this is a core problem or if the problem is the modifications that get made to the UI if the editor is not a true admin.

swirtSJW commented 1 year ago

@xiongjaneg and @jilladams This is one that I do not think sits with Facilities.

jilladams commented 1 year ago

Ok, noted. Tagging with CMS Team for now. Ownership Qs will get followed up next week when Erika's back online, related to this Slack thread: https://dsva.slack.com/archives/C03LFSPGV16/p1697128201027809

laflannery commented 1 year ago

I believe this is coming out of the draggable table interface from Drupal core. It would be good to compare if Detail pages also have this problem as they use the same interface on field_content_block. It would help rule out if this is a core problem or if the problem is the modifications that get made to the UI if the editor is not a true admin.

In answer to this comment above, I tested quite a few other content types and screens and did not find this issues anywhere else.

swirtSJW commented 1 year ago

Related conversation in slack. Based on Laura's findings this does seem like it is specific to Centralized Content.

laflannery commented 1 year ago

@jilladams Did we determine ownership yet? I just was cleaning CMS things up and wanted to make sure it was in the right place