Fac: Update Google maps driving directions links in Facilities products to meet UX, Analytics, A11y standards

[jilladams]

User Story or Problem Statement

We want to standardize the handling of Google maps directions links to meet a11y, Analytics, & UX standards. We had done some of this in previous tickets (#14309, #13837, #12085) however since then guidance has changed again.

We need go back and confirm everything is updated for the new, finalized guidance.

Additional Context

https://github.com/department-of-veterans-affairs/va.gov-cms/issues/14309#issuecomment-1759545976

ACs

• [ ] The directions links should be programmatically unique and provide information as to the location the directions pertain using the sr-only pattern
• [ ] All links should open in the smae tab
• [ ] Links should not have the noreferrer attribute
• [ ] All directions links visually say "Get Directions on Google Maps"
• [ ] Accessibility review

[eselkin]

Putting a note here where to find the main facility listing & satellite listings google directions links (they are in content-build in src/site/includes/directions-google-maps.liquid).

[mmiddaugh]

@laflannery can you give this a defect level to assist with prioritization, please?

[mmiddaugh]

@laflannery - should we divide this work out to make it easier to pull in a product specific increment? (i.e. quick win for Facility Locator)?

[laflannery]

@mmiddaugh I think that's a question for you, @Agile6MSkinner and maybe engineers? Because I think this is possibly bigger than just the directions links but here are all my thoughts:

• The title of this ticket says something about analytics, is that being handled separately with the work Randi is potentially going to be doing? Should this even be being considered here?
• We need to make sure all our links adhere to the new, finalized external link guidance, not just the Directions links so it seems odd to just focus on those
• Some ways we could think about handling this:
  1. Within individual tickets as an AC.
     • For example, the ticket we looked at earlier today, events pagination. We could potentially add an AC to review all links in that same template/file to make sure they follow external link guidance because the engineer would already be in the file and that might be efficient.
  2. Wait and do this as part of the AP migration
     • We will be going over the code closely anyway, doing clean up (hopefully) but we could add this to the list of things we want to look closely at and not simply port over as is from content-build to next-build templates
  3. Individaul tickets itself, not tied to ACs elsewhere
     • Meaning I would create a ticket for "Update links in Facility locator", "Update links in VBA", etc.
     • I would want to be sure we knew exactly what we were doing, going back to my original question about the analytics and if that is involved in any way.
  4. Leave this ticket as it is, a larger effort, but just make it clear exactly what we are doing and cleaning up.
     • Seems like possibly not the route you would prefer based on your original question because a larger ticket makes it harder to pull into a sprint with other work but I still wanted it in my list of thoughts

[Agile6MSkinner]

I like option ii because it seem to me like maximizing for work not done. And with the amount of stuff on our plate right now, that's a serious concern if we want to accomplish our goals for this qtr.