department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

[CONSIDER] Should CMS be source of truth for facility map thumbnails #15672

Open swirtSJW opened 1 year ago

swirtSJW commented 1 year ago

User Story or Problem Statement

Currently for VAMC and Vet Center CMS based pages, there is a map thumbnail that is generated from a lookup of lat lon via Facility API (via VetsAPI). THe makes the Facility API the source of truth. The problem is that Facility API being the source of truth makes VAST the source of truth and sometimes VAST is delayed. (related slack thread) This sometimes creates a situation where Veterans are show a map that is not an accurate depiction of where the facility is.

The CMS contains the lat lon fields as well (also sourced from the Facility API) but there is a the allowance that if a lat lon was truly wrong and needed to be changed, we could overide it in the CMS until such time that VAST caught up. If we used the CMS facility data to pass the lat lon to mapbox we could make the change neccesary to provide Veterans with a more timely/accurate representation of where a facility is.

Risks

  1. Facility Locator and CMS could disagree about the location shown. Facility locator would still show the wrong location and the CMS page would show the correct location.
  2. CMS altered data could be overwitten in the CMS if something else about the facility changed in the Facility API (phone number, status, name...) Which would cause the CMS to go back to showing the incorrect VAST location for the facility.

image

Description or Additional Context

Steps for Implementation

Acceptance Criteria

Team

Please check the team(s) that will do this work.

swirtSJW commented 1 year ago

This is not an urgent or even a must do. Just something to ponder if the benefit is worth it for the few times we might need it.

Agile6MSkinner commented 2 months ago

@davidmpickett @mmiddaugh This came up in planning today. Do we want to make a call on it?