department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Drupal: Police page centralized content #15710

Closed xiongjaneg closed 1 year ago

xiongjaneg commented 1 year ago

User Story or Problem Statement

Police page centralized content will include:

Needs scope of content for text fields Michelle and Dave to provide here

Resources

Acceptance Criteria

Team

Facilities

davidmpickett commented 1 year ago

Per Jordan's updated design - definitions of terms image

davidmpickett commented 1 year ago

I was not able to do detailed spec for this as part of #15756. Would recommend adding my time doing that to the front end of this ticket and make this a 5. (Similar to what we did for #15911)

davidmpickett commented 1 year ago

Content spec

Content 1

Content 2

Content 3

Content 4

davidmpickett commented 1 year ago

Adding this marked up image from Michelle as is has some content feedback not reflected in the sketch file. VA Police with content input markup

swirtSJW commented 1 year ago

This page has been created as described. https://prod.cms.va.gov/centralized-content/vamc-system-va-police-page-content

swirtSJW commented 1 year ago

There is no PR associated with this since the Centralized Content is just content. @thejordanwood , @laflannery and @davidmpickett this page https://prod.cms.va.gov/centralized-content/vamc-system-va-police-page-content is ready for the three of you to look over.

laflannery commented 1 year ago

No comments from me since as you pointed out this is just content and the content type was already reviewed

davidmpickett commented 1 year ago

This matches the spec. No changes needed to the Drupal configuration unless there is a significant unforeseen design shift.

Next steps for content updates: I suggest treating this node as the source of truth for this content for purposes of CAIA review.

The "what do these terms mean" section is already out of date. Will need to match the words actually used in the stat boxes, which shifted in the last design.

Screenshot 2023-11-13 162212

@mmiddaugh @xiongjaneg Do you feel like the labels of those boxes are stable now? Any new insights / curveballs out of the data meeting last week?

xiongjaneg commented 1 year ago

@davidmpickett This Slack thread that you were in lists the ideal fields we wanted from the vendor

thejordanwood commented 1 year ago

@swirtSJW The content type looks good to me! As Dave pointed out, the actual content on the FE page may change but the Drupal configuration for this matches the spec.

swirtSJW commented 1 year ago

Thanks all. Sounds like we can call this ticket done.

xiongjaneg commented 1 year ago

Submitted in Platform collab cycle ticket

jilladams commented 1 year ago

Closed based on comment thread while prepping sprint report. If this needs reopened for some reason, please tag me for awareness.