department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Rework Cypress VAMC Banner feature to not collide with existing content #15811

Open swirtSJW opened 1 year ago

swirtSJW commented 1 year ago

User Story or Problem Statement

Currently our tests/cypress/integration/features/content_type/full_width_banner_alert.feature has the last 1/3 of the test disabled. It was disabled by https://github.com/department-of-veterans-affairs/va.gov-cms/issues/15809 to urgently get CI working again.

Since a system is only allowed to have one system banner alert published, it is impossible to have the test publish one. That is the cause of the failure.

The long term fix is to re-design the test to not collide with actual data. Currently, banner alert tests can’t be edited after publishing, which creates a discrepancy for banner testing (can’t create more than one banner).

Possible solutions

A) make the systems that the test applies to a unique combination of systems (like three systems on radically different parts of the country) It would be unlikely that a broad combination of three would ever have a joint banner. B) Uses a new system that is essentially the isle of lost toys that is not a legit system but is only used for tests. This might be a shell system to park these things for later (since deleting these would delete all the history that goes with them).

Acceptance Criteria

swirtSJW commented 1 year ago

Isle of lost toys ticket https://github.com/department-of-veterans-affairs/va.gov-cms/issues/13842