department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
90 stars 66 forks source link

Broken ARIA references Image List Content Type in CMS #15821

Open laflannery opened 8 months ago

laflannery commented 8 months ago

Describe the defect

Within the edit screens on the Image List content type, there are multiple aria-describedby attributes that do not correspond to an ID anywhere on the page.

AC / Expected behavior

Screenshots

Screenshot of the Page Introduction field error from AMP plugin. The aria-describedby attribute is pointing to something with the ID edit-field-intro-text-limited-html-0--description but if I search for that ID I can't find it anywhere on the page, it doesn't exist.

image

Screenshot of where the attribute is on the <div> image

Accessibility Standard

WCAG version 2.0 A, Criterion 1.3.1

Team

Please check the team(s) that will do this work.

laflannery commented 8 months ago

I put the CMS label as a placeholder cause I'm not sure who this belongs to

laflannery commented 8 months ago

@EWashb (or maybe @jilladams) are you able to tell me who owns Checklist, I can't tell from this mural who should be assigned this ticket

jilladams commented 8 months ago

Great question that I also need to ask from a different ticket today. For reference: there are ~2~ 6 checklist nodes in the whole CMS, both in draft. I suspect DaveC knows the history, but I'll give Erika first right to opine about ownership, before pulling him in. ;)

EWashb commented 8 months ago

I found 6 checklists in draft right now and they are all tied to Resources and Support content. I don't have the historical context of the intent of this content type, but I would agree that if they only exist currently within a PW product, that they are a PW product. I am open to conversation if folks feel otherwise. @jilladams @laflannery

laflannery commented 8 months ago

I saw a convo in slack that led me to putting this under PW ownership

FranECross commented 7 months ago

@laflannery We don't feel we'll be able to answer these questions/AC (below). Are you able to instead provide recommendations on what should be done?