department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
97 stars 69 forks source link

SPIKE: Verify that Benefit Hub and Benefit Detail Page left navs only show published content #15907

Open jilladams opened 11 months ago

jilladams commented 11 months ago

User story

AS A content editor I WANT only published content to appear in the left nav of Benefit pages SO THAT users are not exposed to broken links to draft content

Description

There is a known issue in the FE where sometimes Draft content appears in the Left Nav, if parent menu settings are configured on Draft content. This is done in Menu settings on the node.

The front-end should only show menu items for published nodes.

According to Swirt, this was fixed for all Facility pages back when AdHoc held the Facilities FE contract (by Michael Bell Sherman? Check the name with Swirt.) We need to make sure the same fix is applied on Benefit pages. It may be, or it may not be.

Example

Any draft Benefit Detail page: https://prod.cms.va.gov/admin/content?title=&type=page&moderation_state=draft&owner=All

Where:

Even with parent menu link set, Draft nodes should not appear in prod left nav.

Additional notes

This issue came up originally with respect to Dark launches.

We would ideally like to know also whether dark launched nodes that aren't built to production will / won't appear in production menus. Need to refine and figure out if that's reasonable to include in ACs or not.

ACs

FranECross commented 1 month ago

@FranECross Check with CAIA to see if they have a checklist to ensure this is covered. Then close this.