department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

[Find Forms] Replace MomentJS with date-fns #16185

Open randimays opened 1 year ago

randimays commented 1 year ago

Description

Application: Find Forms

According to the MomentJS Docs, MomentJS is a legacy project in maintenance mode. This means no new features or capabilities, no major changes, possibly no bug/quirk fixes, and no bundle size fixes.

MomentJS is a significantly larger JS library than alternatives like date-fns. We should migrate to date-fns to improve package size for our application. We may see tiny improvements in performance, but the biggest gain here is moving to a package that is actively supported/improved and more likely to have support for new browsers going forward.

User story

AS A PO/PM for Find Forms I WANT a JS library that is not obsolete/in maintenance mode SO THAT the code is in a package that is active supported/improved, will be maintained and fixed if issues arise, and more likely to have support for new browsers going forward.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

FranECross commented 6 days ago

Identified as a possible 'code freeze' time candidate.