search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Tugboat content releases do not correctly reference some assets (e.g. CSS). #16237

Open ndouglas opened 11 months ago

ndouglas commented 11 months ago

Description

See this Slack thread.

Content releases on Tugboat use a buildtype of vagovdev since #1700, following #1630.

This code inserts URLs pointing to S3 buckets unless the buildtype is set to localhost.

Consequently, local changes to these files will not be picked up in the built frontend, as they reference those in the content.dev.va.gov S3 bucket.

We should probably change our buildtype back to localhost or add a new buildtype, tugboat. The abstraction is leaky but it would probably take more effort than it is worth to fix at that level. This may take some discovery to determine an appropriate approach.

Acceptance Criteria

ndouglas commented 11 months ago

Hey team! Please add your planning poker estimate with Zenhub @edmund-dunn @JunTaoLuo @tonytaylor @ariperez @olivereri @teeshe