Front end templates for Vet Center shows both common and official names (for other nearby vet centers)

[maxx1128]

[2024-09-04] - still blocked by #15445 and Lighthouse, because Nearby locations for Vet Centers is driven by Lighthouse (not editor input)

Problem statement

Veterans may know and search for their closest Vet Center by a common name, rather than an official name. Vet Center common names should be displayed along with official names to help Veterans identify and locate their Vet Centers.

This ticket is related to #15424, since updating the names for nearby vet centers on location pages involves changes made in vets-website and vets-api, which is out of the scope of the rest of the ticket work. So changes for that specific part of the page have been moved to this ticket so the rest is not blocked.

Background

The Outstation associated with Salt Lake City Vet Center is displayed using only the Official name. The Common name concept needs to be available for Outstations as well.

Example: Major Brent Taylor Vet Center Outstation (node/17527), associated with Salt Lake City Vet Center

CMS and FE screenshots

[Private Zenhub Image](https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBZzNkIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--28c78c896ee1f339cda8dec32d062c36e2494f64/image.png) Test cases should come from Tugboat data

Current behavior

15424 lists all the current behavior of this bug. This ticket only lists one example (the second of three total examples) for this ticket's specific scope. The first and third examples are to only be addressed in pull requests connected to the original ticket.

• A Vet Center is identified only by the official name when listed as a nearby Location on another Vet Center's page.
  • Example 1: Dr. Cameron McKinley Department of Veterans Affairs Veterans Center (Prescott Vet Center) as displayed as a nearby location for West Valley Vet Center
  • Example 2: Col. Gail S. Halvorsen 'Candy Bomber' Veterans Center (Provo Vet Center) as displayed as a nearby location for Salt Lake City Vet Center

Expected behavior

• Displayed names for Vet Centers and Outstations use both a official/legislated name and a common name.

Tickets

• This ticket tracks content-build changes

• 15424 tracks vets-website changes

Acceptance Criteria

• [ ] ~Listings for a location with both an official and common name displays both names when listed as the Main location area on its own Locations page~
• [ ] ~Listings for a location with both an official and common name displays both names when listed as a Satellite locations on the main Vet Center's Locations page~
• [ ] Listings for a location with both an official and common name displays both names when listed as a nearby location on another Vet Center's Locations page
• [ ] All markup identified above (regarding the id and aria-describedby attributes) should be followed wherever the official name appears
• [ ] Design Review
• [ ] Accessibility Review

QA

• [ ] Go to West Valley Vet Center locations page and confirm that in the nearby locations section:
  • [ ] Each location has a common name displaying as <h3>
  • [ ] If there is an official name, it is displaying a <p> (Prescott should)
  • [ ] When an official name is present, both names are tied together using id/aria-describedby pattern
  • [ ] When an official name is not present, the common name does not have an aria-describedby attribute

Team

Please check the team(s) that will do this work.

• [ ] CMS Team
• [ ] Public Websites
• [x] Facilities
• [ ] User support
• [ ] Accelerated Publishing

[maxx1128]

While I'm creating the ticket, I will add an estimate of a 5. It will take changes in two repos: vets-website (which should be relatively simple, just the markup at src/applications/static-pages/facilities/vet-center/NearByVetCenters.jsx) and vets-api (which will be more complicated due to adding data at the endpoint at modules/facilities_api/app/controllers/facilities_api/v1/va_controller.rb).

[davidmpickett]

Are we sure this isn't blocked by #15445? Nearby Vet Centers uses the Facilities API and Common Name isn't available in there. Or will this be some kind of joint React and GraphQL partnership?