Front end: Vet Center unpublished services should not be showing on VA.gov

[xiongjaneg]

User Story or Problem Statement

As a Veteran, I want to know which services are available at my Vet Center and should not see services that aren't available.

As a Vet Center editor, I want to show only services that are available at my Vet Center and my Vet Center page shouldn't show services that aren't available that I've unpublished.

Per Slack thread, unpublished Vet Center services should not be showing on VA.gov.

Per Steve in Slack, The Vet Center services query is not filtering for Published (status)

Sequencing for launch

August 15 change management will unblock Drupal #18003 to merge the Drupal PR. This ticket should follow #18003 merge and use the Graph QL from that branch / PR.

Acceptance Criteria

• [x] The Vet Center services query filters for Published status.
  • [x] If the service isn't Published, it doesn't show on VA.gov.

    
    ### Tasks

• [x] Verify "Draft", "Archives," "In Review," and "Approved" don't show on the front end
• [x] Verify that "published" services show on front end

[davidmpickett]

IMO there are a few different phases here:

• [x] Content model / UX / Drupal -> SPIKE proposed path(s) for Vet Center editors to publish services
  • There are a lot of gnarly implications to changing this, so I don't think we'll be able to hash all of them out via refinement alone, will need some dedicated time to exploring/documenting/conferring
• [x] Product approves/chooses path
• [ ] Drupal implementation
• [ ] Updates to FE query to filter by Published

[mmiddaugh]

Re: option to add a View Block of services to the Dashboard which would direct editors to admin/content filtered properly for services and their vet section

Notable differences in editorial experience

• current admin/content workflow does not distinguish required services (which cannot be removed by editor) from optional services (which editors can remove)
• the method for adding a service in the current admin/content workflow takes the editor to "Add content" menu which adds risk for confusion, at a minimum
• current admin/content workflow does not display the national description, which could introduce risk for editors to duplicate the description
  existing service edit view

admin/content service edit view


[mmiddaugh]

If we get into Dashboard changes related to this, #7269 Improve Vet Center editor experience - dashboard and other may be relevant

[davidmpickett]

Historical ticket noting the ambiguity of Vet Center service moderation state: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/7144

[davidmpickett]

Re: option to add a View Block of services to the Dashboard which would direct editors to admin/content filtered properly for services and their vet section

Notable differences in editorial experience

• current admin/content workflow does not distinguish required services (which cannot be removed by editor) from optional services (which editors can remove)

It might be important to note that the only thing currently preventing Vet Center editors from Archiving Required Services is the fact that they are unlikely to ever go to admin/content. Required services aren't actually structurally different than non-required services in a content moderation workflow sense.

On Staging as a Vet Center editor, I was able to Archive a required service in my section

Although give that unpublished services are currently showing up on VA.gov, even archiving a service wouldn't necessarily remove it. 🤯

[xiongjaneg]

@xiongjaneg There is an accompanying Drupal ticket. This is not blocked by Drupal.

When we do this on front end, there will be change management with editors who have what they thought were published services but with this fix, these services will not be published.

[xiongjaneg]

This fix may also have the advantage of making it apparent to editors when they've only saved in Draft and never Published, because when they check their published page, draft content won't show.

[xiongjaneg]

Some of these issues may be impacted by the inline editor ticket #15125. Should this wait? Likely no, there is risk in publishing content not intended for publishing.

[mmiddaugh]

@xiongjaneg depending on level of effort, Vet Center service editorial UX does not show national description #17177 may need to ride along with this work

[xiongjaneg]

blocked by IEF removal ticket

[swirtSJW]

This is blocked because currently if an editor edits a VetCenter Service, due to IEF, they do not have the option to publish their change. So if we stop showing draft content, they have no way to get new edits out to the FE.

[jilladams]

This change would mean that the 30 draft services that currently appear in the front-end need to be published in order to continue appearing on the FE.

We need to do CM for editors before we make this change.

[Agile6MSkinner]

@mmiddaugh is working with VetCenters with draft services to get them addressed. @mmiddaugh should we consider this one unblocked per our conversation?

[mmiddaugh]

@eselkin For validation purposes, here are a few Vet Center services in draft as of this morning

• Ponce Vet Center
  • Whole health
  • LGBTQ+ Veteran care
  • Intimate partner violence support
• Kona Vet Center
  • Workshops and classes
• Seattle Vet Center
  • Women Veteran care
  • Minority Veteran care
  • LGBTQ+ Veteran care

I did not see any of these services displayed on the relevant pages in Prod

[jilladams]

That's a verification in prod! Closing.