Whitelist Twitter/X links to prevent broken link alerts at top of nodes

[xiongjaneg]

User Story or Problem Statement

"As an Drupal editor, I don't want to be alerted to a broken link to my Twitter/X page when it isn't really broken."

This is happening as Twitter/X has transitioned to requiring login to view Twitter/X pages.

To replicate

1. Log in to any VAMC system page (e.g., https://prod.cms.va.gov/maine-health-care)
2. See the broken link message for Twitter/X.
3. Click the link to see the link is valid.

Acceptance Criteria

• [ ] Links to VA X sites are added to the list of broken links to ignore in the Node Link Report.
• [ ] VA X sites don't appear in broken link alerts at the top of View and Edit pages.

[xiongjaneg]

@maortiz-27-80 Submitted for your team's consideration, thank you!

[BerniXiongA6]

@maortiz-27-80 I'm going to remove the needs analysis label and place this into pre-refinement review for us so it doesn't get lost.

[xiongjaneg]

Taking back into Facilities work related to X and because it mostly affects Facilities pages.

[xiongjaneg]

If Twitter/X is always behind a login wall, we would never know if it was a broken link. So the question may be moot.

[xiongjaneg]

@jilladams @FranECross Would you please review and discuss with Dave C. if there's any risk to your products if Twitter/X is whitelisted across the board?

[xiongjaneg]

Some events editors are adding links to Twitter. Events adds Twitter/X links on the front end.

Amanda referenced this use case Outreach And Events | VA Gaming Outreach: Regiment Gaming VA General Q&A | Veterans Affairs

[xiongjaneg]

prod.cms.va.gov/admin/config/content/node_link_report may be the place to add this

[jilladams]

Re: Events:

Some events editors are adding links to Twitter. Events adds Twitter/X links on the front end.

There isn't a field for Twitter stuff on Event nodes: https://prod.cms.va.gov/node/add/event. So: the CMS for Events is agnostic about Twitter, and Editors shouldn't be seeing broken link warnings, unless maybe an editor includes a Twitter URL in the rich text field for event description. In that case, yes, whitelisting may be necessary.

On Events in FE, there is a "Share to twitter" URL. That's built by the front-end. Spot checking from Outreach Events, that's working fine on most events, just requires a login if you're not already

Sidebar: Unrelated bug

I did just run into a bug while confirming all this: if an editor includes a pipe in the Event title, it causes the Twitter window to 400 error: https://www.va.gov/outreach-and-events/events/64661/:

• Link that 400s: https://twitter.com/intent/tweet?text=757%20Military%20Community%20Education%20|%20DoD%20Skillbridge%20Connect%20(Peninsula)%20-%20%20Newport%20News,%20VA&url=https://www.va.gov/outreach-and-events/events/64661
• Remove the Pipe and this link works: https://twitter.com/intent/post?text=757%20Military%20Community%20Education%20%20DoD%20Skillbridge%20Connect%20(Peninsula)%20-%20%20Newport%20News%2C%20VA&url=https%3A%2F%2Fwww.va.gov%2Foutreach-and-events%2Fevents%2F64661

I'll ticket that.

[mmiddaugh]

Spoke with @davidconlon about this - let's hold on proceeding pending a bigger conversation with Erika

• Twitter/X links may not all be the same so we may want to think through a more targeted approach
  • If the link is broad "Follow VHA" type, the Veteran is more likely to expect to log in
  • If the link goes to a single tweet or is a one-off, the Veteran may just need the details and not plan to be a frequent visitor to Twitter/X.
• This likely will need editor support for best practices when linking to Twitter/X