VBA RO preview observations to address before launch

[xiongjaneg]

Description

This is a placeholder ticket to capture questions or comments about VBA RO pilot MVP before launch. Subsequent tickets may need to be stubbed from these observations.

Preview observations, resolved as of 3.25.2024

• The VA benefits hotline number is displayed as VA benefits hotline: 800-827-1000, ext. 4023022840 in the FE and in the data. I'm not entirely sure where the extension came from. There is no extension on the VBA Regional Offices website.
• Get updates box has a blank spot and is not rendering the "Subscribe to our newsletter" link in the data

Screenshots

Screenshots of the VA benefits hotline number


Get updates screenshots


[mmiddaugh]

~Not sure if the "Other nearby VA locations" part has been wired yet - the heading renders but no locations are included.~ resolved as of 3.25.2024

Screenshot


[mmiddaugh]

I'm not sure this help text is entirely meaningful but it could benefit from a space between to and local in any case. (It may make sense to address this as part of Review error states recommendations and feasibility for VBA content types #16906)

Screenshot

[mmiddaugh]

@laflannery - Does "Can't find the service you're looking for?" have the correct heading level? I did not expect it to have a jumplink - it seems out of place to assume at the top of the page that I can't find what I am looking for.... Perhaps it's because the Services header and service accordions aren't yet present in this preview? Preview staging link

Screenshot

[laflannery]

@mmiddaugh So it is but I don't disagree with you about the anchor link, here's my problem:

I originally, based on what I was seeing from Sketch, said this should be an H3. Which meant it would NOT show in the "On this page" list. My reasoning was that it was a child of "Other services" which made sense to me:

However, I did just ask this to be updated to an H2 because the logic I thought was built into this block was not what I thought. This block just shows if it's added into the CMS and when an example page was created I saw an instance that didn't make sense to me - where "Can't find the service you're looking for?" was a child of "Veteran Benefits".

To me those two things felt more like siblings, not parent and child, especially if this can show anywhere under any accordion section. That was why I asked for this to change to an H2, the consequence of that is now it's in the "On this page".

Questions:

• Was my sibling vs parent/child relationship decision accurate? Maybe I am misunderstanding and it actually is parent/child regardless of where it shows up.
• If the heading level is correct as an H2, maybe there is a way we can exclude this particular heading from "On this page". We could ask the engineers if that's possible?Update 1/30/24: Max doesn't see a way for us to manually exclude a particular heading so if we decided to keep this an H2, it's going to have to remain in the "On this page"

Let me know if you want to sync on this because I realize that was a lot of info.

[mmiddaugh]

@laflannery and I are on the same page about "Can't find what you're looking for"

• the link is an escape hatch with the same weight as the service categories - which dictates an H2
• being an H2 means it will get a jump link, even if it's a little awkward

The good news is that it will can serve Veterans and other beneficiaries who need additional help, whether they realize they need it at the top or bottom of the page.

[davidmpickett]

I'm not sure this help text is entirely meaningful but it could benefit from a space between to and local in any case. (It may make sense to address this as part of Review error states recommendations and feasibility for VBA content types #16906)

Screenshot

We are currently unable to change the interface text in this section. This is a CMS Team issue (#16452) that would need to be resolved.

The issue with the spacing seems to be a regression. "to" and the following label are actually entirely separate elements. If you highlight them, you can see there are two overlapping highlights.

They were properly spaced back in December as seen in my screenshot on the linked issue.

This regression is not specific to Facilities, as it can be seen in on similar interfaces on Public Websites. For instance, Resources and Support Detail page content type.

[mmiddaugh]

see also: "Additional Hours Options" shows as Italics on VBA #17686

[jilladams]

I'm looking through VBA stuff and came across this ticket for the first time. Can y'all confirm that the intent here is that any feedback out of Editor training sessions comes here for review / to be ticketed?

If so, I think Dave's comment 2 up is a dangler with no ticket? https://github.com/department-of-veterans-affairs/va.gov-cms/issues/16901#issuecomment-2024244708

In the spirit of simplifying onboarding / expectations for a new PM, how would you feel about us closing this and just cutting new tickets for anything identified during sessions? (@laflannery @mmiddaugh )

[laflannery]

I'm not actually sure what the original intention of this ticket was here tbh. I personally agree with your idea of just making individual tickets though, I think that's easier than a group ticket approach like this.

[davidmpickett]

Spun out my comment into a separate ticket so this can close https://github.com/department-of-veterans-affairs/va.gov-cms/issues/17831